Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated baselines by 1ES Pipeline Templates #4309

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

microsoft-github-policy-service[bot]
Copy link
Contributor

No description provided.

@ellismg
Copy link
Member

ellismg commented Sep 11, 2024

FWIW, the cred-scan violation is from this code in a test file:

	// Standard secrets
	expectedPassword := "P@55w0rd!"
	err = azdConfig.SetSecret("secrets.password", expectedPassword)
	require.NoError(t, err)

	err = azdConfig.SetSecret("infra.provisioning.sqlPassword", expectedPassword)
	require.NoError(t, err)

In this case, P@55w0rd! is not a real password and we are not leaking anything.

I can go change this string to something else if that's going to make cred-scan happy, but I'd rather just add some indefinite baseline (or annotate it in the source such that Cred Scan starts to ignore it). @weshaggard do you know what the best thing for me to do here is? I noticed in this generated file the baseline had an expiration date and we need a long term story for this test code.

@weshaggard
Copy link
Member

Baselining is only supposed to be temporary. We will want to add this to the suppression file instead https://github.com/Azure/azure-dev/blob/main/eng/CredScanSuppression.json, see https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/623/Cred-scan-failure-troubleshooting

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not merge this as @benbp and I are still figuring out some of this baselining stuff.

@benbp
Copy link
Member

benbp commented Sep 12, 2024

Will merge #4312 then this.

@benbp
Copy link
Member

benbp commented Sep 18, 2024

/check-enforcer override

@benbp benbp merged commit d91c739 into main Sep 18, 2024
3 checks passed
@benbp benbp deleted the users/merlinbot/1es-pt-auto-baselining-pr branch September 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants