-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Preflight Validate API support #4329
Open
hemarina
wants to merge
22
commits into
Azure:main
Choose a base branch
from
hemarina:preflight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b4f6a3 - Browse repository at this point
Copy the full SHA 4b4f6a3View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c267fd - Browse repository at this point
Copy the full SHA 4c267fdView commit details
Commits on Aug 30, 2024
-
exec: Don't depend on internals of
os.Process
(Azure#4233)To assign the process to the job object after we create it, we need the `windows.Handle` that backs the process we started with `os/exec`. This was not exported and so we used some gnarly casting to cast the `os.Process` to a structure we authored that had the same layout of `os.Process` so we could grab the handle property. This is unsafe if the layout of the `os.Process` changes, which it did in Go 1.23. Move to code that doesn't depend on the internals of `os.Process` by using the exported Pid to call `windows.OpenProcess` to get a handle and then pass that along to `windows.AssignProcessToJobObject`.
Configuration menu - View commit details
-
Copy full SHA for 1dd2246 - Browse repository at this point
Copy the full SHA 1dd2246View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24bef4f - Browse repository at this point
Copy the full SHA 24bef4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7392da7 - Browse repository at this point
Copy the full SHA 7392da7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fd5d08 - Browse repository at this point
Copy the full SHA 5fd5d08View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4531513 - Browse repository at this point
Copy the full SHA 4531513View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d955428 - Browse repository at this point
Copy the full SHA d955428View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 59c65f0 - Browse repository at this point
Copy the full SHA 59c65f0View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e17c1db - Browse repository at this point
Copy the full SHA e17c1dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 932cba3 - Browse repository at this point
Copy the full SHA 932cba3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ae5dc1 - Browse repository at this point
Copy the full SHA 4ae5dc1View commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7bab2e2 - Browse repository at this point
Copy the full SHA 7bab2e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad148b - Browse repository at this point
Copy the full SHA 5ad148bView commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0aba62a - Browse repository at this point
Copy the full SHA 0aba62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca49e0d - Browse repository at this point
Copy the full SHA ca49e0dView commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3264e88 - Browse repository at this point
Copy the full SHA 3264e88View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f676913 - Browse repository at this point
Copy the full SHA f676913View commit details -
Configuration menu - View commit details
-
Copy full SHA for efa28b8 - Browse repository at this point
Copy the full SHA efa28b8View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e4d915 - Browse repository at this point
Copy the full SHA 9e4d915View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd915cf - Browse repository at this point
Copy the full SHA dd915cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38bc6e2 - Browse repository at this point
Copy the full SHA 38bc6e2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.