Use next available port when the default port is already used #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PramodValavala-MSFT
requested review from
AnatoliB and
michaelpeng36
as code owners
|
@kshyju I noticed you flagged this for discussion, have you looked into this further? |
| .Where(l => l.Port >= startPort) | ||
| .Select(l => l.Port)); | ||
|
|
||
| usedPorts.Sort(); |
There was a problem hiding this comment.
Why sorting is needed for all used ports, thats an additional complexity of O(NlogN). You are iterating over all the values in usedPorts.
You have two options,
- Used HashSet and iterate over all the values and lookup will be O(N), then you can do startPort++ and keep looking.
- Used TreeSet or SortedSet to store and look for value less than startPort.
| } | ||
| startPort++; | ||
| } | ||
|
|
There was a problem hiding this comment.
What if all ports are exhausted, then should we log the errors?
| @@ -33,5 +37,33 @@ public static int GetAvailablePort() | |||
| listener.Stop(); | |||
| } | |||
| } | |||
|
|
|||
| public static int GetNextAvailablePort(int startPort) | |||
| { | |||
There was a problem hiding this comment.
ArgumentExceptin when startPort is either using for system process or upper limit of 65536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with multiple function apps locally, every function host apart from the first needs to have a different port manually set either via the command line argument
--portor theHost.LocalHttpPortproperty inlocal.settings.json. Also, in some cases the default port might be blocked with another process (sometimes an olderfuncitself that didn't terminate).This PR adds support to pick up the next available port (7072, 7073, ...) when none is provided. If a port is defined in either place mentioned above, this would not do anything.
One known issue is that multiple function apps run at the exact same time might end up picking the same port, causing one of them to error out. This is present even today with the static default port, primarily because the validation is done before the host starts up.