-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - Refactor .NET 8 detection to eliminate FUNCTIONS_INPROC_NET8_ENABLED #4248
base: main
Are you sure you want to change the base?
Conversation
Refactor the way .NET 8 projects are detected by removing the `IsInProcDotNet8Enabled` method and introducing `DotnetHelpers.IsDotNet8` which checks the target framework in the `.csproj` file. Updated `StartHostAction.cs` methods to use the new detection logic and added necessary `using` directives and methods in `DotnetHelpers.cs`. Adjusted tests in `StartHostActionTests.cs` to align with the new logic.
@saadalia please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This suggestion could help us eliminate the need for FUNCTIONS_INPROC_NET8_ENABLED
Refactor the way .NET 8 projects are detected by removing the
IsInProcDotNet8Enabled
method and introducingDotnetHelpers.IsDotNet8
which checks the target framework in the.csproj
file. UpdatedStartHostAction.cs
methods to use the new detection logic and added necessaryusing
directives and methods inDotnetHelpers.cs
. Adjusted tests inStartHostActionTests.cs
to align with the new logic.Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist