-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - Refactor .NET 8 detection to eliminate FUNCTIONS_INPROC_NET8_ENABLED DLL approach #4249
base: main
Are you sure you want to change the base?
Conversation
Removed IsInProcDotNet8Enabled from StartHostAction.cs and updated methods to use DotnetHelpers.IsDotNet8() for .NET 8 detection. Added IsDotNet8 and GetTargetFramework methods to DotnetHelpers.cs for framework inspection. Introduced GetScriptFilePath in ExtensionsHelper.cs to extract script file paths from function.json. Updated ValidateHostRuntimeAsync_MatchesExpectedResults test to pass boolean directly.
@saadalia please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Update target framework detection and add new method
Refactor the way .NET 8 projects are detected by removing the IsInProcDotNet8Enabled method and introducing DotnetHelpers.IsDotNet8.
The
IsDotNet8
method uses the main DLL file to determine the target framework. Additionally, a new methodGetScriptFilePath
has been added toExtensionsHelper.cs
to retrieve the script file path, but it is currently incomplete and requires further implementation.Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist