Adding a timeout to IFunctionProvider.GetFunctionMetadataAsync
#10249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if a provider does not return, it will not cause a deadlock state.
kshyju
commented
Jun 25, 2024
kshyju
changed the title
IFunctionProvider.GetFunctionMetadataAsync
…h can be set to a different value than default, from the tests.
jviau
approved these changes
Jun 27, 2024
fabiocav
reviewed
Jun 28, 2024
| var getFunctionMetadataFromProviderTask = functionProvider.GetFunctionMetadataAsync(); | ||
| var delayTask = Task.Delay(TimeSpan.FromSeconds(MetadataProviderTimeoutInSeconds)); | ||
|
|
||
| var completedTask = Task.WhenAny(getFunctionMetadataFromProviderTask, delayTask).ContinueWith(t => |
There was a problem hiding this comment.
It's a bit painful that this lives in WebJobs.Script (and that it targets .NET standard). WaitAsync would be a cleaner approach.
…r method throws or when the operation timeseout.
kshyju
commented
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10219
The fix is to wrap the
GetFunctionMetadataAsyncwith a timeout task so that if theGetFunctionMetadataAsyncdoes not return within a specific time, we throw a timeout exception which the caller will handle.IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md