Refactor CI artifacts for release improvements#10704
Merged
Conversation
jviau
changed the title
jviau
force-pushed
the
jviau/eng/no-zip
branch
from
2c2640c to
9adf37f
Compare
liliankasem
reviewed
Jan 22, 2025
liliankasem
reviewed
Jan 22, 2025
liliankasem
reviewed
Jan 22, 2025
kshyju
reviewed
Jan 23, 2025
Member
|
zipping Symbols don't need JITTrace insertion. Do they? why we don't zip it anymore? |
Contributor
Author
The way zipping worked it is easier to not zip all instead of only some. We are going to have the release pipeline perform zipping. But I am separately looking into uploading symbols directly to the public symbol server, which will remove the need for this artifact entirely. |
liliankasem
reviewed
Jan 24, 2025
liliankasem
approved these changes
Jan 24, 2025
Member
liliankasem
left a comment
liliankasem
left a comment
There was a problem hiding this comment.
lgtm; just need to fix the default bitness in the script
Co-authored-by: Lilian Kasem <likasem@microsoft.com>
kshyju
approved these changes
Jan 24, 2025
jviau
added a commit
that referenced
this pull request
Jan 24, 2025
* Consolidate artifacts * Disable sdl spotBugs * Remove PrivateSiteExtension * stage release_notes.md as artifact * Add script to generate private site extension * Copy release_notes.md in site extension * Flatten SiteExtension artifacts, custom hash task * Generate release.json during build * modifyOutputPath: false * Use SHA256 for the hash * Default private siteext to 64bit * Default private siteext to zipping * Remove binlog artifact to save space * Update SiteExtension readme * Update src/WebJobs.Script.SiteExtension/New-PrivateSiteExtension.ps1 Co-authored-by: Lilian Kasem <likasem@microsoft.com> --------- Co-authored-by: Lilian Kasem <likasem@microsoft.com>
jviau
added a commit
that referenced
this pull request
Jan 28, 2025
* Refactor CI artifacts for release improvements (#10704) * Consolidate artifacts * Disable sdl spotBugs * Remove PrivateSiteExtension * stage release_notes.md as artifact * Add script to generate private site extension * Copy release_notes.md in site extension * Flatten SiteExtension artifacts, custom hash task * Generate release.json during build * modifyOutputPath: false * Use SHA256 for the hash * Default private siteext to 64bit * Default private siteext to zipping * Remove binlog artifact to save space * Update SiteExtension readme * Update src/WebJobs.Script.SiteExtension/New-PrivateSiteExtension.ps1 Co-authored-by: Lilian Kasem <likasem@microsoft.com> --------- Co-authored-by: Lilian Kasem <likasem@microsoft.com> * Fix MinorVersionPrefix * Fix nuget_drop_path * Fix modifyOutputPath: false * Publish site-ext to sub-folders per tfm --------- Co-authored-by: Lilian Kasem <likasem@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10762
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
This PR refactors our build artifacts to support the upcoming release improvements. The changes are:
drop_windowsartifact.release.jsonas a build artifact indrop_windows. This is used by the release pipeline for creating the GitHub release.New-ReleaseJson.ps1scriptdrop_linuxfor consistency with windows drop.GetFileHas_Custommsbuild task to work around an issue with file path length in the existing msbuild task.