Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow snake case for binding names #10764

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Allow snake case for binding names #10764

wants to merge 12 commits into from

Conversation

satvu
Copy link
Member

@satvu satvu commented Jan 23, 2025

Issue describing the changes in this PR

resolves #9917. Allows for binding names to use snake case.

Related documentation issue: #10781

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional tests were run on the Python side for v1 and v2 here as well.

Additional sign-offs were acquired offline from other language worker owners (Powershell, Java, Node).

@satvu satvu requested a review from gavin-aguiar January 27, 2025 23:42
@satvu satvu assigned hallvictoria and unassigned hallvictoria Jan 27, 2025
@satvu satvu requested review from hallvictoria and mathewc January 27, 2025 23:43
@mathewc
Copy link
Member

mathewc commented Jan 28, 2025

Please link to the relevant work items for this, and also fill out the template section above with all the details, etc.

@satvu satvu marked this pull request as ready for review January 28, 2025 21:46
@satvu satvu requested a review from a team as a code owner January 28, 2025 21:46
@satvu satvu requested review from mathewc and fabiocav January 28, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timer Trigger arg_name cannot use snake case
4 participants