-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow snake case for binding names #10764
Open
satvu
wants to merge
12
commits into
dev
Choose a base branch
from
satvu/test-snake-case
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+42
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
Jan 27, 2025
satvu
commented
Jan 27, 2025
satvu
commented
Jan 27, 2025
test/WebJobs.Script.Tests/Description/FunctionDescriptorProviderTests.cs
Show resolved
Hide resolved
satvu
commented
Jan 27, 2025
mathewc
reviewed
Jan 28, 2025
mathewc
reviewed
Jan 28, 2025
Please link to the relevant work items for this, and also fill out the template section above with all the details, etc. |
hallvictoria
approved these changes
Jan 28, 2025
satvu
commented
Jan 30, 2025
mathewc
approved these changes
Jan 30, 2025
liliankasem
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #9917. Allows for binding names to use snake case.
Related documentation issue: #10781
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional tests were run on the Python side for v1 and v2 here as well.
Additional sign-offs were acquired offline from other language worker owners (Powershell, Java, Node).