Remove redundant project config, add file-scoped namespaces #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattchenderson
force-pushed
the
mattchenderson/templatecleanup
branch
from
760e2cd to
1a87801
Compare
jviau
approved these changes
Dec 4, 2024
| <ItemGroup> | ||
| <Using Include="System.Threading.ExecutionContext" Alias="ExecutionContext"/> | ||
| </ItemGroup> | ||
| <!--#endif --> | ||
| <!--#if (NetFramework)--> | ||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
| namespace Company.Function | ||
| namespace Company.Function; | ||
|
|
||
| public class BlobTriggerCSharp |
There was a problem hiding this comment.
Could also use primary constructors.
Suggested change
| public class BlobTriggerCSharp | |
| public class BlobTriggerCSharp(ILogger<BlobTriggerCSharp> logger) |
Then don't even have the _logger field. You can access the ctor parameter anywhere in this class via logger.
| { | ||
| _logger = loggerFactory.CreateLogger<CosmosDBTriggerCSharp>(); | ||
| } | ||
| public CosmosDBTriggerCSharp(ILoggerFactory loggerFactory) |
There was a problem hiding this comment.
Recommend primary constructor and also switching to ILogger<CosmosDBTriggerCSharp>
| { | ||
| using var blobStreamReader = new StreamReader(stream); | ||
| var content = await blobStreamReader.ReadToEndAsync(); | ||
| _logger.LogInformation($"C# Blob Trigger (using Event Grid) processed blob\n Name: {name} \n Data: {content}"); |
There was a problem hiding this comment.
We should probably not encourage bad logging practices in our samples (but not sure if that is in the scope of this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up templates by removing some verbosity. Some of the settings in the project template have been unnecessary since the SDK provides many of these behaviors already. Of note, we're also removing the reference to
Microsoft.Azure.Functions.Worker.Extensions.HttpwhenMicrosoft.Azure.Functions.Worker.Extensions.Http.AspNetCoreis included, since it's already pulling it in transitively. For the item templates, we're just moving to file-scoped namespaces (which involves removing indentation and is making the diff messy), as that gets rid of a small bit of clutter.