Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the logic to fetch the sha value from the correct file #543

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Jun 25, 2024

Issue

The feed generation logic was updated to add v0 tags for net 8 inproc. Below is sample of the value of the core tools property. Here the SHA value mentioned in the property is actually for file https://functionscdn.azureedge.net/public/4.0.5858/Azure.Functions.Cli.win-x86.4.0.5858.zip. The updated logic had failed to take into account _net8 string added to the name and was reading the incorrect sha value.

{
    "OS": "Windows",
    "Architecture": "x86",
    "downloadLink": "https://functionscdn.azureedge.net/public/4.0.5858/Azure.Functions.Cli.win-x86_net8.4.0.5858.zip",
    "sha2": "448ec30de82f04caebd46f238280c4d104ffaf4b5da97a9bd6d24a391ef831ce",
    "size": "full",
    "default": "false"
}

Fix

The PR takes into account _net8 string addition to the file name and reads the correct value.

@soninaren soninaren requested a review from a team as a code owner June 25, 2024 21:11
@soninaren soninaren merged commit f8e7d22 into main Jun 25, 2024
4 checks passed
@soninaren soninaren deleted the nasoni/shaValidatiion branch June 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants