New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling feed updates to support .NET 9 #549

Merged

surgupta-msft merged 19 commits into release/main from surgupta/net9-update

Aug 6, 2024

Contributor

surgupta-msft commented Jul 10, 2024 •

edited

Loading

resolves #550

Tooling feed updates to support .NET 9

Diff between 4.84.0 and 4.85.0 - https://gist.github.com/surgupta-msft/737c4f7048bc5df898ca0bfaa5ee253c/revisions

Diff between net8 and net9 - https://gist.github.com/surgupta-msft/0f978c67ee04aa2cf0cc9dfd0b27a851/revisions

surgupta-msft added 2 commits

July 8, 2024 16:51


          Initial changes for net9

2526b1a


          Changes for Net9

cf9f505

surgupta-msft requested a review from a team as a code owner

July 10, 2024 21:19

surgupta-msft commented

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

surgupta-msft commented

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

surgupta-msft commented

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

surgupta-msft commented

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

surgupta-msft requested review from kshyju, mattchenderson and soninaren

July 10, 2024 22:27

kshyju reviewed

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

kshyju reviewed

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved


          Updating in process changes

9bbbd61

kshyju reviewed

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

aishwaryabh mentioned this pull request

Core Tools .NET 9 Changes Azure/azure-functions-core-tools#3764

Merged

5 tasks


          End of life date update for Net9

e40d94e

mattchenderson previously requested changes

View reviewed changes

cli-feed-v4.json Show resolved Hide resolved

cli-feed-v4.json Outdated Show resolved Hide resolved

cli-feed-v4.json Outdated Show resolved Hide resolved

cli-feed-v4.json Outdated Show resolved Hide resolved

cli-feed-v4.json Outdated Show resolved Hide resolved

mattchenderson reviewed

View reviewed changes

cli-feed-v4.json Outdated Show resolved Hide resolved

surgupta-msft added 6 commits

July 19, 2024 15:38


          Addressing PR feedback

9eb362c


          Made net9 hidden

c14c43e


          Merge remote-tracking branch 'origin/release/main' into surgupta/net9…

0ff7f84

…-update


          Update project and item templates version

712503a


          Merge branch 'release/main' into surgupta/net9-update

7c8aad4


          update project templates version

1479a19

surgupta-msft requested a review from mattchenderson

July 22, 2024 23:13


          Addressing PR feedback

92fb310

surgupta-msft requested a review from kshyju

July 25, 2024 22:36

surgupta-msft added 3 commits

July 26, 2024 16:09


          Merge branch 'release/main' into surgupta/net9-update

3dbaba8


          Update preview sdk package for testing

df477ca


          Removed net5-isolated

1abcd51

surgupta-msft added 2 commits

August 1, 2024 11:28


          Updating sdk

1531aef


          Removing net5 isolated

980505f

Contributor Author

surgupta-msft commented Aug 1, 2024

Few things have been identified to come up in the follow-up PR -

Unhide Net9-isolated
Add endOfLifeDate once the date is available for Net9 GA
Update worker.sdk version with Net9 support once the package is GA
Update coretools links when these changes are released

mattchenderson reviewed

View reviewed changes

Contributor

mattchenderson left a comment

changes seem good overall - my only question is if net5-isolated needs to be removed at this time. I'd probably rather see that be a separate set of changes if we're going to be doing that, unless it is required as part of getting net9 out.

mattchenderson dismissed their stale review

August 2, 2024 22:30

Stale review - changes have since come in

mattchenderson requested changes

View reviewed changes

Contributor

mattchenderson left a comment

Changing the positioning back to "request changes" to ensure .NET 5 is not removed with this PR.

fabiocav reviewed

View reviewed changes

Member

fabiocav left a comment

Agree with @mattchenderson 's comment about .NET 5 here.

It's something we should be doing, but needs coordination and shouldn't be combined in this PR

surgupta-msft added 2 commits

August 5, 2024 10:12


          Revert "Removing net5 isolated". This reverts commit 980505f.

67f258b


          Reverting net5-isolated changes

d684079

mattchenderson approved these changes

View reviewed changes

kshyju approved these changes

View reviewed changes

cli-feed-v4.json Show resolved Hide resolved


          Updating latest version of templates

171686f

surgupta-msft merged commit 5b9f13e into release/main

5 checks passed

surgupta-msft deleted the surgupta/net9-update branch

August 6, 2024 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment