Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json 401 error #545

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Fix json 401 error #545

merged 9 commits into from
Aug 26, 2024

Conversation

mayamarom10
Copy link
Member

  1. Updated handle_http_error func to handle 401 errors.
  2. Updates client.py to check if json is empty before parsing.

Copy link

github-actions bot commented Jul 2, 2024

Test Results

    6 files  ± 0      6 suites  ±0   17m 48s ⏱️ - 5m 7s
  294 tests + 2    268 ✅ + 2   26 💤 ±0  0 ❌ ±0 
1 764 runs  +12  1 608 ✅ +12  156 💤 ±0  0 ❌ ±0 

Results for commit a13be3f. ± Comparison against base commit f578429.

♻️ This comment has been updated with latest results.

@@ -564,3 +565,11 @@ async def test_streaming_ingest_from_blob(self, is_managed_streaming):
self.streaming_ingest_client.ingest_from_blob(blob_descriptor, ingestion_properties)

await self.assert_rows_added(2, timeout=120)

def test_json_401(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be UT?

AsafMah
AsafMah previously approved these changes Aug 25, 2024
@mayamarom10 mayamarom10 merged commit f90f2d2 into master Aug 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants