Test false "false positive" for ProvisioningStateMustBeReadOnly #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkhilaIlla
changed the title
ravimeda
approved these changes
Jul 25, 2023
rkmanda
reviewed
Jul 26, 2023
| @@ -212,6 +212,106 @@ test("ProvisioningStateMustBeReadOnly should find errors when multiple verbs spe | |||
| }) | |||
| }) | |||
|
|
|||
| test("ProvisioningStateSpecified should find errors when readOnly property is present in the envelope property", () => { | |||
| const oasDoc = { | |||
There was a problem hiding this comment.
really nice to see this test being added!
|
I'm still receiving many false positives for the ProvisioningStateMustBeReadOnly check #637. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule ProvisioningStateMustBeReadOnly was disabled due to
[LintDiff][False positive] ProvisioningStateMustBeReadOnly · Issue #6191 · Azure/azure-sdk-tools (github.com)
Sample PR's:
[AutoSync] API spec updates for containerservice/official/fleet-api-release by AzureRestAPISpecReview · Pull Request #12357 · Azure/azure-rest-api-specs-pr (github.com)
Added draft API spec for Liftr PureStorage by pratikgawali-msft · Pull Request #12320 · Azure/azure-rest-api-specs-pr (github.com)
In this PR I reproduced the same scenario and added tests and the rule works as expected. I also enabled the rule in staging.