Change disableForTypeSpec to disableForTypeSpecDataPlane
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
requested review from
rkmanda,
mikeharder and
weshaggard
as code owners
mikeharder
reviewed
Jun 14, 2024
packages/azure-openapi-validator/autorest/src/spectral-plugin-func.ts
Outdated
Show resolved
Hide resolved
mikeharder
previously requested changes
Jun 14, 2024
… marked as such in the ruleset
konrad-jamrozik
force-pushed
the
users/kojamroz/dp_disable
branch
from
dd4d18b
to
3d7094d
Compare
konrad-jamrozik
requested review from
bdefoy,
tejaswiMinnu and
AkhilaIlla
as code owners
konrad-jamrozik
changed the title
disableForTypeSpec to disableForTypeSpecDataPlane
konrad-jamrozik
dismissed
mikeharder’s stale review
Getting approval from Wes Haggard while Mike is out.
weshaggard
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can disable rules only if
resolvedOpenapiType === OpenApiTypes.dataplaneObsolete description:
Now if rule is marked asdisableForTypeSpec: trueit will continue to be enabled for TypeSpec in case of ARM and RPaaS rulesets. I mean merged/final ruleset.