-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XmsPageableForListCalls - added subscription path to test #715
Conversation
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
Agree with Akhila, I missed that it's a point get and should not be pageable
...azure/openapi-validator-rulesets/tejaswis-test-XmsPageableForListCalls_2024-06-19-19-02.json
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
Nit - please update the PR description based on Roopesh's comment #715 (comment) |
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/functions/xms-pageable-for-list-calls.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/functions/xms-pageable-for-list-calls.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XmsPageableForListCalls test dint have the test case for the path "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Music/Configurations/{config1}", and this rule must not throw an error for this pattern
Updated code to bypass point get calls and added more tests