XmsPageableForListCalls - added subscription path to test #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejaswiMinnu
requested review from
rkmanda,
konrad-jamrozik,
mikeharder and
weshaggard
as code owners
bdefoy
previously approved these changes
Jun 19, 2024
rkmanda
reviewed
Jun 19, 2024
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
AkhilaIlla
reviewed
Jun 19, 2024
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
bdefoy
dismissed
their stale review
Agree with Akhila, I missed that it's a point get and should not be pageable
...azure/openapi-validator-rulesets/tejaswis-test-XmsPageableForListCalls_2024-06-19-19-02.json
Outdated
Show resolved
Hide resolved
bdefoy
reviewed
Jun 24, 2024
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
|
Nit - please update the PR description based on Roopesh's comment #715 (comment) |
AkhilaIlla
reviewed
Jun 24, 2024
AkhilaIlla
reviewed
Jun 24, 2024
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
AkhilaIlla
reviewed
Jun 24, 2024
packages/rulesets/src/spectral/functions/xms-pageable-for-list-calls.ts
Outdated
Show resolved
Hide resolved
bdefoy
reviewed
Jun 28, 2024
packages/rulesets/src/spectral/functions/xms-pageable-for-list-calls.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
bdefoy
reviewed
Aug 15, 2024
bdefoy
approved these changes
Aug 15, 2024
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
packages/rulesets/src/spectral/test/xms-pageable-for-list-calls.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XmsPageableForListCalls test dint have the test case for the path "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Music/Configurations/{config1}", and this rule must not throw an error for this pattern
Updated code to bypass point get calls and added more tests