Update Restore-AzRecoveryServicesBackupItem to support restore to NoZone. #27052
+3,981
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.Network
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Restore-AzRecoveryServicesBackupItem | 7 | 8 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. | -WLRecoveryConfig | Assign value for $AnotherInstanceWithLogConfig. | |
| Restore-AzRecoveryServicesBackupItem | 9 | 4 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. | -RestoreDiskList | Assign value for $restoreDiskLUNs. | |
| Restore-AzRecoveryServicesBackupItem | 13 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. | -Item | Assign value for $item. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Restore-AzRecoveryServicesBackupItem | 7 | 8 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -WLRecoveryConfig $AnotherInstanceWithLogConfig is a null-valued parameter value. | -WLRecoveryConfig | Assign value for $AnotherInstanceWithLogConfig. | |
| Restore-AzRecoveryServicesBackupItem | 9 | 4 | Unassigned_Variable | Restore-AzRecoveryServicesBackupItem -RestoreDiskList $restoreDiskLUNs is a null-valued parameter value. | -RestoreDiskList | Assign value for $restoreDiskLUNs. | |
| Restore-AzRecoveryServicesBackupItem | 13 | 3 | Unassigned_Variable | Get-AzRecoveryServicesBackupRecoveryPoint -Item $item is a null-valued parameter value. | -Item | Assign value for $item. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
hiaga
approved these changes
Jan 29, 2025
| if (rp.RecoveryPointTier != 0 | ||
| && rp.RecoveryPointTier != RecoveryPointTier.VaultArchive | ||
| && rp.RecoveryPointTier != RecoveryPointTier.SnapshotAndVaultArchive | ||
| && rp.RecoveryPointTier != RecoveryPointTier.Snapshot) |
There was a problem hiding this comment.
are we allowing restore from SnapshotAndVaultStandard RP ? If yes, do we not have the 4HRs restriction on it now ?
There was a problem hiding this comment.
In order to have restores form snapshot we used to have restriction of 4 HRs. But now restore from snapshot is blocked from all the regions. In the case of SnapshotAndVaultStandard RP, restore will fall happen from vault standard RP.
|
|
||
| ### Example 11: Edge zone restore for a managed AzureVM to alternate location | ||
| ### Example 11: Cross zonal restore for to non-ZonePinned VM to NoZone |
There was a problem hiding this comment.
I will correct it.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NoriZC
approved these changes
Feb 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
…one. (#27052) * Support for NoZone as targetZone for RestoreAzureRmRecoveryServicesBackupItem * Update in readme * minor change * Update ChangeLog for upcoming release changes --------- Co-authored-by: NoriZC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Restore-AzRecoveryServicesBackupItem to enable restore to the NoZone by accepting an input of 0 for the -TargetZoneNumber parameter. Additionally, this PR blocks cross-zonal restoration from snapshot RP
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.