Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.TrustedSigning] Adding generated cmdlets for GA #27070

Closed

Conversation

janielMartell
Copy link

@janielMartell janielMartell commented Feb 4, 2025

Description

In this PR, we are adding a new set of cmdlets to the Az.TrustedSigning module.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@janielMartell janielMartell marked this pull request as ready for review February 5, 2025 21:40
@Jaxelr Jaxelr requested review from Jaxelr, isra-fel and Copilot February 5, 2025 21:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 356 out of 371 changed files in this pull request and generated 3 comments.

Files not reviewed (15)
  • src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.csproj: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.nuspec: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.psd1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.psm1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/UX/Microsoft.CodeSigning/codeSigningAccounts-certificateProfiles.json: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/UX/Microsoft.CodeSigning/codeSigningAccounts.json: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/build-module.ps1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/check-dependencies.ps1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/create-model-cmdlets.ps1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/custom/Az.TrustedSigning.custom.psm1: Language not supported
  • src/TrustedSigning/TrustedSigning.Autorest/README.md: Evaluated as low risk
  • src/TrustedSigning/TrustedSigning.Autorest/custom/README.md: Evaluated as low risk
  • src/TrustedSigning/TrustedSigning.Autorest/docs/Az.TrustedSigning.md: Evaluated as low risk
  • src/TrustedSigning/TrustedSigning.Autorest/docs/Get-AzTrustedSigningAccount.md: Evaluated as low risk
  • src/TrustedSigning/TrustedSigning.Autorest/docs/Get-AzTrustedSigningCertificateProfile.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/TrustedSigning/TrustedSigning.Autorest/docs/New-AzTrustedSigningAccount.md:100

  • [nitpick] Clarify the purpose of the DefaultProfile parameter or improve its description.
The DefaultProfile parameter is not functional.


### Example 1: Create new trusted signing certificate Profile
```powershell
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest
Copy link
Preview

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the ResourceGroupName parameter. It should be rg-test instead of reg-test.

Suggested change
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName rg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options

### Example 1: Create new trusted signing certificate Profile
```powershell
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest
Copy link
Preview

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect use of a colon instead of an equals sign for the ProfileType parameter. It should be -ProfileType=PublicTrustTest.

Suggested change
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType=PublicTrustTest

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Comment on lines +146 to +147
The geo-location where the resource lives

Copy link
Preview

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should be 'The geographic location where the resource resides'.

Suggested change
The geo-location where the resource lives
The geographic location where the resource resides

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link

github-actions bot commented Feb 7, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@NoriZC
Copy link
Contributor

NoriZC commented Feb 7, 2025

This PR should be raised based on generation branch. Provided documents for author offline. @janielMartell if any concern you can reach to me directly

@NoriZC NoriZC closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants