-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Az.TrustedSigning] Adding generated cmdlets for GA #27070
[Az.TrustedSigning] Adding generated cmdlets for GA #27070
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 356 out of 371 changed files in this pull request and generated 3 comments.
Files not reviewed (15)
- src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.csproj: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.nuspec: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.psd1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/Az.TrustedSigning.psm1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/UX/Microsoft.CodeSigning/codeSigningAccounts-certificateProfiles.json: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/UX/Microsoft.CodeSigning/codeSigningAccounts.json: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/build-module.ps1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/check-dependencies.ps1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/create-model-cmdlets.ps1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/custom/Az.TrustedSigning.custom.psm1: Language not supported
- src/TrustedSigning/TrustedSigning.Autorest/README.md: Evaluated as low risk
- src/TrustedSigning/TrustedSigning.Autorest/custom/README.md: Evaluated as low risk
- src/TrustedSigning/TrustedSigning.Autorest/docs/Az.TrustedSigning.md: Evaluated as low risk
- src/TrustedSigning/TrustedSigning.Autorest/docs/Get-AzTrustedSigningAccount.md: Evaluated as low risk
- src/TrustedSigning/TrustedSigning.Autorest/docs/Get-AzTrustedSigningCertificateProfile.md: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/TrustedSigning/TrustedSigning.Autorest/docs/New-AzTrustedSigningAccount.md:100
- [nitpick] Clarify the purpose of the DefaultProfile parameter or improve its description.
The DefaultProfile parameter is not functional.
|
||
### Example 1: Create new trusted signing certificate Profile | ||
```powershell | ||
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the ResourceGroupName
parameter. It should be rg-test
instead of reg-test
.
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest | |
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName rg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
### Example 1: Create new trusted signing certificate Profile | ||
```powershell | ||
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect use of a colon instead of an equals sign for the ProfileType
parameter. It should be -ProfileType=PublicTrustTest
.
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType:PublicTrustTest | |
New-AzTrustedSigningCertificateProfile -AccountName test -ResourceGroupName reg-test -ProfileName test -IdentityValidationId 5ab4583e-d027-4998-9d65-a2e88981829f -ProfileType=PublicTrustTest |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
The geo-location where the resource lives | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be 'The geographic location where the resource resides'.
The geo-location where the resource lives | |
The geographic location where the resource resides |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
This PR should be raised based on generation branch. Provided documents for author offline. @janielMartell if any concern you can reach to me directly |
Description
In this PR, we are adding a new set of cmdlets to the
Az.TrustedSigning
module.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.