[PS] Migrate ManagedServiceIdentity module to autorest v4 #27350
+782
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Pan-Qi
reviewed
Mar 24, 2025
| "Az.ManagedServiceIdentity","Get-AzFederatedIdentityCredential","Get-AzFederatedIdentityCredential","0","3000","The type of property 'Audience' of type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServiceIdentity.Models.Api20230131.IFederatedIdentityCredential' has changed from 'System.String[]' to 'System.Collections.Generic.List`1[System.String]'.","Change the type of property 'Audience' back to 'System.String[]'." | ||
| "Az.ManagedServiceIdentity","New-AzFederatedIdentityCredential","New-AzFederatedIdentityCredential","0","3000","The type of property 'Audience' of type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServiceIdentity.Models.Api20230131.IFederatedIdentityCredential' has changed from 'System.String[]' to 'System.Collections.Generic.List`1[System.String]'.","Change the type of property 'Audience' back to 'System.String[]'." | ||
| "Az.ManagedServiceIdentity","Update-AzFederatedIdentityCredential","Update-AzFederatedIdentityCredential","0","3000","The type of property 'Audience' of type 'Microsoft.Azure.PowerShell.Cmdlets.ManagedServiceIdentity.Models.Api20230131.IFederatedIdentityCredential' has changed from 'System.String[]' to 'System.Collections.Generic.List`1[System.String]'.","Change the type of property 'Audience' back to 'System.String[]'." | ||
| "Az.ManagedServiceIdentity","Update-AzFederatedIdentityCredential","Update-AzFederatedIdentityCredential","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzFederatedIdentityCredential' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzFederatedIdentityCredential'." |
There was a problem hiding this comment.
Double check with Xiaogang, if removing "AllParameterSets" should be reported.
Pan-Qi
requested changes
Mar 25, 2025
|
Hi Bernard,
As I know, the old variant should be replaced by two parts to remove variants.
To match variants
More variants will be generated in v4, like (parent pipeline input, via JSON string, Update), directives to match variants need to be more precise while renaming, removing or hiding variants. For example:
To remove create variants take identity as pipeline input:
- where:
variant: ^CreateViaIdentity.*$
remove: true
To remove non-expanded create or update variants:
- where:
variant: ^(Create|Update)(?!.*?Expanded)
remove: true
________________________________
From: Qi Pan
Sent: Tuesday, March 25, 2025 1:06 PM
To: Azure/azure-powershell
Cc: Joyer Jin (Wicresoft North America Ltd); Author
Subject: Re: [Azure/azure-powershell] [PS] Migrate ManagedServiceIdentity module to autorest v4 (PR #27350)
@Pan-Qi requested changes on this pull request.
________________________________
In src/ManagedServiceIdentity/ManagedServiceIdentity.Autorest/README.md<#27350 (comment)>:
@@ -58,7 +61,11 @@ directive:
- where:
subject: UserAssignedIdentity
- variant: ^Create$|^CreateViaIdentity$|^CreateViaIdentityExpanded$|^Update$|^UpdateViaIdentity$
CreateViaIdentityExpanded will not be removed
________________________________
In src/ManagedServiceIdentity/ManagedServiceIdentity.Autorest/README.md<#27350 (comment)>:
@@ -113,7 +120,12 @@ directive:
- where:
subject: FederatedIdentityCredential
- variant: ^Create$|^CreateViaIdentity$|^CreateViaIdentityExpanded$|^Update$|^UpdateViaIdentity$
Same as above
—
Reply to this email directly, view it on GitHub<#27350 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3W2AV76KXQNAUFJVJT5TC32WDP6JAVCNFSM6AAAAABZE6AQCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJSGM4DOMRWGI>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.