[NetAppFiles] Change to api-version 2024-09-01 #27360

audunn · 2025-03-17T19:56:59Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-03-17T19:57:03Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

notyashhh · 2025-03-18T00:23:12Z

/azp run

audunn · 2025-03-18T12:52:34Z

/azp run

azure-pipelines · 2025-03-18T12:52:40Z

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

notyashhh · 2025-03-18T13:02:34Z

/azp run

azure-pipelines · 2025-03-18T13:02:49Z

Azure Pipelines successfully started running 3 pipeline(s).

audunn · 2025-03-18T14:16:31Z

/azp run

azure-pipelines · 2025-03-18T14:16:42Z

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

notyashhh · 2025-03-19T01:15:07Z

/azp run

azure-pipelines · 2025-03-19T01:15:23Z

Azure Pipelines successfully started running 3 pipeline(s).

github-actions · 2025-03-19T03:35:16Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

audunn · 2025-03-19T10:21:08Z

/azp run

azure-pipelines · 2025-03-19T10:21:15Z

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

audunn · 2025-03-20T09:55:01Z

/azp run

azure-pipelines · 2025-03-20T09:55:08Z

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

vidai-msft · 2025-03-20T13:10:09Z

/azp run

azure-pipelines · 2025-03-20T13:10:35Z

Azure Pipelines successfully started running 3 pipeline(s).

audunn · 2025-03-20T13:44:40Z

When approved is it possible to relase asap? This contains feature that has been announced but was missing from the PowerShell module?

src/NetAppFiles/NetAppFiles.Test/ScenarioTests/AccountTests.cs

audunn · 2025-03-27T15:17:50Z

/azp run

azure-pipelines · 2025-04-03T07:18:20Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2025-04-04T05:28:33Z

/azp run

azure-pipelines · 2025-04-04T05:28:48Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2025-04-04T06:51:15Z

hi @audunn , please re-record 'Test-AccountCMK', it was not correctly recorded before because az.keyvault was not set up properly

audunn · 2025-04-04T10:26:47Z

hi @audunn , please re-record 'Test-AccountCMK', it was not correctly recorded before because az.keyvault was not set up properly
@VeryEarly Looks like it is failing to load the nested extension Az.KeyVault.Extension, the Az.KeyVault.Extension module is there in the artifacts directory in a folder

  Message: 
System.Management.Automation.RuntimeException : Test failed due to a non-empty error stream. First error: PowerShell Error Record: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
Exception:System.Management.Automation.PSInvalidOperationException: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\*****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
 ---> System.IO.FileNotFoundException: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\*****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
   --- End of inner exception stack trace ---
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifest(String moduleManifestPath, ExternalScriptInfo manifestScriptInfo, Hashtable data, Hashtable localizedData, ManifestProcessingFlags manifestProcessingFlags, Version minimumVersion, Version maximumVersion, Version requiredVersion, Nullable`1 requiredModuleGuid, ImportModuleOptions& options, Boolean& containedErrors)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifest(ExternalScriptInfo scriptInfo, ManifestProcessingFlags manifestProcessingFlags, Version minimumVersion, Version maximumVersion, Version requiredVersion, Nullable`1 requiredModuleGuid, ImportModuleOptions& options)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModule(PSModuleInfo parentModule, String fileName, String moduleBase, String prefix, SessionState ss, Object privateData, ImportModuleOptions& options, ManifestProcessingFlags manifestProcessingFlags, Boolean& found, Boolean& moduleFileFound)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModule(String fileName, String moduleBase, String prefix, SessionState ss, ImportModuleOptions& options, ManifestProcessingFlags manifestProcessingFlags, Boolean& found)
   at Microsoft.PowerShell.Commands.ImportModuleCommand.ImportModule_LocallyViaName(ImportModuleOptions importModuleOptions, String name)

VeryEarly · 2025-04-07T04:28:59Z

it looks like dependency in your local was not built properly.

Please try below and record test again:

.\tools\buildScripts\buildModules.ps1 -TargetModule NetAppFiles

NoriZC · 2025-04-07T06:09:47Z

/azp run

VeryEarly · 2025-04-07T06:09:58Z

/azp run

azure-pipelines · 2025-04-07T06:10:03Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2025-04-07T06:10:10Z

Azure Pipelines successfully started running 3 pipeline(s).

… ANF-48265-netapp-2024-09-01

audunn · 2025-04-07T14:29:32Z

/azp run

azure-pipelines · 2025-04-07T14:29:38Z

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

audunn · 2025-04-07T14:32:06Z

@VeryEarly for some reason this did not work in the first go but did after re-trying and re-building. I cannot run pipeline can you run it to verify?

dolauli · 2025-04-08T01:30:20Z

/azp run

azure-pipelines · 2025-04-08T01:30:36Z

Azure Pipelines successfully started running 3 pipeline(s).

audunn · 2025-04-08T09:00:44Z

@VeryEarly Still fails in pipeline but works in local. Seems like the error is in Set-AzKeyVaultAccessPolicy calling Graph client
We need help to resolve this as this is cause massive delays.

EXEC : PowerShell error Record: Unable to find a matching HTTP request for URL 'POST /v1.0/directoryObjects/microsoft.graph.getByIds'. Calling method Item(). [D:\a\_work\1\s\build.proj]
  Exception:System.Collections.Generic.KeyNotFoundException: Unable to find a matching HTTP request for URL 'POST /v1.0/directoryObjects/microsoft.graph.getByIds'. Calling method Item().
      at Microsoft.Azure.Commands.TestFx.Recorder.Records.get_Item(String key) in D:\a\_work\1\s\tools\TestFx\Recorder\Records.cs:line 53
      at Microsoft.Azure.Test.HttpRecorder.HttpMockServer.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in D:\a\_work\1\s\tools\TestFx\DelegatingHandlers\HttpMockServer.cs:line 138
      at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperations.GetByIdsWithHttpMessagesAsync(Body body, Dictionary`2 customHeaders, CancellationToken cancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperationsExtensions.GetByIdsAsync(IDirectoryObjectsOperations operations, Body body, CancellationToken cancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperationsExtensions.GetByIds(IDirectoryObjectsOperations operations, Body body)
      at Microsoft.Azure.Commands.KeyVault.ModelExtensions.GetObjectsByObjectIds(List`1 objectIds, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\ModelExtensions.cs:line 199
      at Microsoft.Azure.Commands.KeyVault.ModelExtensions.ToPSKeyVaultAccessPolicies(IEnumerable`1 accessPolicies, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\ModelExtensions.cs:line 243
      at Microsoft.Azure.Commands.KeyVault.Models.PSKeyVault..ctor(Vault vault, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\PSKeyVault.cs:line 51
      at Microsoft.Azure.Commands.KeyVault.Models.VaultManagementClient.UpdateVault(PSKeyVault existingVault, PSKeyVaultAccessPolicy[] updatedPolicies, Nullable`1 updatedEnabledForDeployment, Nullable`1 updatedEnabledForTemplateDeployment, Nullable`1 updatedEnabledForDiskEncryption, Nullable`1 updatedSoftDeleteSwitch, Nullable`1 updatedPurgeProtectionSwitch, Nullable`1 updatedRbacAuthorization, Nullable`1 softDeleteRetentionInDays, PSKeyVaultNetworkRuleSet updatedNetworkAcls, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\Client\VaultManagementClient.cs:line 302
      at Microsoft.Azure.Commands.KeyVault.SetAzureKeyVaultAccessPolicy.ExecuteCmdlet() in D:\a\_work\1\s\src\KeyVault\KeyVault\Commands\SetAzureKeyVaultAccessPolicy.cs:line 558
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.<>c__3`1.<ExecuteSynchronouslyOrAsJob>b__3_0(T c)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.ExecuteSynchronouslyOrAsJob[T](T cmdlet, Action`1 executor)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.ExecuteSynchronouslyOrAsJob[T](T cmdlet)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet.ProcessRecord()
  Details:
  Script Stack Trace: at Test-AccountCMK, D:\a\_work\1\s\src\NetAppFiles\NetAppFiles.Test\bin\Debug\net8.0\ScenarioTests\AccountTests.ps1: line 276

VeryEarly · 2025-04-08T14:04:45Z

@VeryEarly Still fails in pipeline but works in local. Seems like the error is in Set-AzKeyVaultAccessPolicy calling Graph client We need help to resolve this as this is cause massive delays.

EXEC : PowerShell error Record: Unable to find a matching HTTP request for URL 'POST /v1.0/directoryObjects/microsoft.graph.getByIds'. Calling method Item(). [D:\a\_work\1\s\build.proj]
  Exception:System.Collections.Generic.KeyNotFoundException: Unable to find a matching HTTP request for URL 'POST /v1.0/directoryObjects/microsoft.graph.getByIds'. Calling method Item().
      at Microsoft.Azure.Commands.TestFx.Recorder.Records.get_Item(String key) in D:\a\_work\1\s\tools\TestFx\Recorder\Records.cs:line 53
      at Microsoft.Azure.Test.HttpRecorder.HttpMockServer.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in D:\a\_work\1\s\tools\TestFx\DelegatingHandlers\HttpMockServer.cs:line 138
      at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperations.GetByIdsWithHttpMessagesAsync(Body body, Dictionary`2 customHeaders, CancellationToken cancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperationsExtensions.GetByIdsAsync(IDirectoryObjectsOperations operations, Body body, CancellationToken cancellationToken)
      at Microsoft.Azure.Commands.Common.MSGraph.Version1_0.DirectoryObjects.DirectoryObjectsOperationsExtensions.GetByIds(IDirectoryObjectsOperations operations, Body body)
      at Microsoft.Azure.Commands.KeyVault.ModelExtensions.GetObjectsByObjectIds(List`1 objectIds, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\ModelExtensions.cs:line 199
      at Microsoft.Azure.Commands.KeyVault.ModelExtensions.ToPSKeyVaultAccessPolicies(IEnumerable`1 accessPolicies, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\ModelExtensions.cs:line 243
      at Microsoft.Azure.Commands.KeyVault.Models.PSKeyVault..ctor(Vault vault, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\PSKeyVault.cs:line 51
      at Microsoft.Azure.Commands.KeyVault.Models.VaultManagementClient.UpdateVault(PSKeyVault existingVault, PSKeyVaultAccessPolicy[] updatedPolicies, Nullable`1 updatedEnabledForDeployment, Nullable`1 updatedEnabledForTemplateDeployment, Nullable`1 updatedEnabledForDiskEncryption, Nullable`1 updatedSoftDeleteSwitch, Nullable`1 updatedPurgeProtectionSwitch, Nullable`1 updatedRbacAuthorization, Nullable`1 softDeleteRetentionInDays, PSKeyVaultNetworkRuleSet updatedNetworkAcls, IMicrosoftGraphClient graphClient) in D:\a\_work\1\s\src\KeyVault\KeyVault\Models\Client\VaultManagementClient.cs:line 302
      at Microsoft.Azure.Commands.KeyVault.SetAzureKeyVaultAccessPolicy.ExecuteCmdlet() in D:\a\_work\1\s\src\KeyVault\KeyVault\Commands\SetAzureKeyVaultAccessPolicy.cs:line 558
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.<>c__3`1.<ExecuteSynchronouslyOrAsJob>b__3_0(T c)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.ExecuteSynchronouslyOrAsJob[T](T cmdlet, Action`1 executor)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.CmdletExtensions.ExecuteSynchronouslyOrAsJob[T](T cmdlet)
      at Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet.ProcessRecord()
  Details:
  Script Stack Trace: at Test-AccountCMK, D:\a\_work\1\s\src\NetAppFiles\NetAppFiles.Test\bin\Debug\net8.0\ScenarioTests\AccountTests.ps1: line 276

Hi @audunn ,
My bad. Didn't realize this is a data plane cmdlet which cannot be recorded in our test framework for now, I'll mark this new testcase as liveonly (which means it was verified in your local but cannot be record/playback in pr validation). Please let me know if you have concerns.

VeryEarly · 2025-04-08T14:06:39Z

/azp run

azure-pipelines · 2025-04-08T14:07:00Z

Azure Pipelines successfully started running 3 pipeline(s).

audunn · 2025-04-08T14:08:32Z

Hi @audunn ,
My bad. Didn't realize this is a data plane cmdlet which cannot be recorded in our test framework for now, I'll mark this new testcase as liveonly (which means it was verified in your local but cannot be record/playback in pr validation). Please let me know if you have concerns.

@VeryEarly Sounds good to me, no concerns. Thank you

change to api-version 2024-09-01

32d7d4d

help examples

f24c7fb

notyashhh self-assigned this Mar 19, 2025

notyashhh added the needs-revision label Mar 19, 2025

test secret

722eeaf

notyashhh added this to the Az 13.4.0 (04/01/2025) milestone Mar 21, 2025

notyashhh removed the needs-revision label Mar 21, 2025

notyashhh reviewed Mar 21, 2025

View reviewed changes

src/NetAppFiles/NetAppFiles.Test/ScenarioTests/AccountTests.cs Outdated Show resolved Hide resolved

notyashhh modified the milestones: Az 13.4.0 (04/01/2025), Az 13.5.0 (05/06/2025) Mar 24, 2025

tests

a48be0f

audunn and others added 3 commits April 3, 2025 15:32

update help

9141d95

Update NetAppFilesTestRunner.cs

b0d1292

Update NetAppFilesTestRunner.cs

f8569dd

audunn added 2 commits April 7, 2025 11:33

Merge branch 'main' of https://github.com/Azure/azure-powershell into…

c71a98b

… ANF-48265-netapp-2024-09-01

re-test

1158004

Update AccountTests.cs

a129a80

VeryEarly approved these changes Apr 8, 2025

View reviewed changes

NoriZC approved these changes Apr 8, 2025

View reviewed changes

VeryEarly merged commit 0c90114 into Azure:main Apr 8, 2025
12 checks passed

[NetAppFiles] Change to api-version 2024-09-01 #27360

[NetAppFiles] Change to api-version 2024-09-01 #27360

Conversation

audunn commented Mar 17, 2025 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Mar 17, 2025

notyashhh commented Mar 18, 2025

audunn commented Mar 18, 2025

azure-pipelines bot commented Mar 18, 2025

notyashhh commented Mar 18, 2025

azure-pipelines bot commented Mar 18, 2025

audunn commented Mar 18, 2025

azure-pipelines bot commented Mar 18, 2025

notyashhh commented Mar 19, 2025

azure-pipelines bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

audunn commented Mar 19, 2025

azure-pipelines bot commented Mar 19, 2025

audunn commented Mar 20, 2025

azure-pipelines bot commented Mar 20, 2025

vidai-msft commented Mar 20, 2025

azure-pipelines bot commented Mar 20, 2025

audunn commented Mar 20, 2025

audunn commented Mar 27, 2025

azure-pipelines bot commented Apr 3, 2025

VeryEarly commented Apr 4, 2025

azure-pipelines bot commented Apr 4, 2025

VeryEarly commented Apr 4, 2025

audunn commented Apr 4, 2025 • edited Loading

VeryEarly commented Apr 7, 2025

NoriZC commented Apr 7, 2025

VeryEarly commented Apr 7, 2025

azure-pipelines bot commented Apr 7, 2025

azure-pipelines bot commented Apr 7, 2025

audunn commented Apr 7, 2025

azure-pipelines bot commented Apr 7, 2025

audunn commented Apr 7, 2025 • edited Loading

dolauli commented Apr 8, 2025

azure-pipelines bot commented Apr 8, 2025

audunn commented Apr 8, 2025 • edited Loading

VeryEarly commented Apr 8, 2025

VeryEarly commented Apr 8, 2025

azure-pipelines bot commented Apr 8, 2025

audunn commented Apr 8, 2025 • edited Loading

audunn commented Mar 17, 2025 •

edited

Loading

audunn commented Apr 4, 2025 •

edited

Loading

audunn commented Apr 7, 2025 •

edited

Loading

audunn commented Apr 8, 2025 •

edited

Loading

audunn commented Apr 8, 2025 •

edited

Loading