-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test snapshot- delete call portal api #29650
Draft
JackTn
wants to merge
1
commit into
Azure:main
Choose a base branch
from
JackTn:jacktn/test-deletecallportalapi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.12) | new version | base version |
---|---|---|
datafactory.json | 2018-06-01(3f796a7) | 2018-06-01(main) |
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DataFactory/factories' removed or restructured? Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L72:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2018-06 | package-2018-06(3f796a7) | package-2018-06(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.DataFactory/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L56 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L57 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L313 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L398 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L418 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L457 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L657 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L716 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L758 |
ConsistentPatchProperties |
The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L801 |
ConsistentPatchProperties |
The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L801 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L911 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L942 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1136 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1142 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1149 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1182 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1188 |
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1379 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1465 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1471 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1774 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1836 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1878 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1979 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2041 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2083 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2184 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2246 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2288 |
️❌
Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
UNREFERENCED_JSON_FILE |
The example JSON file is not referenced from the swagger file. readme: specification/datafactory/resource-manager/readme.md json: stable/2018-06-01/examples/Factories_List.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 83 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
resource-manager
labels
Jul 1, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BreakingChange-Go-Sdk
BreakingChange-JavaScript-Sdk
BreakingChange-Python-Sdk
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.