Skip to content

Microsoft.OperationalInsights: 2025-02-01 New stable version #31948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Mar 17, 2025

Conversation

roizhv22
Copy link
Member

@roizhv22 roizhv22 commented Dec 22, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Roi Zehavi and others added 6 commits December 8, 2024 17:53
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2023-09-01 to stable/2025-02-01.
Add new properties payload for cluster and workspace
new examples with replication and failover for workspace
Copy link

openapi-pipeline-app bot commented Dec 22, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

common

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 23, 2024
The 201 is not in use. Otherwise fix the exmaple's responses
avoid breaking changee
@kazrael2119
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@roizhv22
Copy link
Member Author

Still in progress

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Feb 17, 2025
@roizhv22
Copy link
Member Author

Comment for activity

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 17, 2025
@roizhv22 roizhv22 removed the no-recent-activity There has been no recent activity on this issue. label Feb 17, 2025
@roizhv22
Copy link
Member Author

roizhv22 commented Mar 3, 2025

comment

@dulikvor dulikvor added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Mar 16, 2025
@ArcturusZhang
Copy link
Member

It is fine that we ignore the failure on azure-sdk-for-net pipeline which causes by duplicate schemas.
By checking the log, it comes from the common-types - which is impossible to resolve them here.
We could resolve them and generate proper .net sdk when you open a PR in azure-sdk-for-net via directives.

@dulikvor
Copy link
Contributor

It is fine that we ignore the failure on azure-sdk-for-net pipeline which causes by duplicate schemas. By checking the log, it comes from the common-types - which is impossible to resolve them here. We could resolve them and generate proper .net sdk when you open a PR in azure-sdk-for-net via directives.

Could you approve the .net step, otherwise the automation won't continue.

@dulikvor dulikvor merged commit 4d97b40 into Azure:main Mar 17, 2025
30 of 31 checks passed
@dulikvor dulikvor added DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Monitor - Operational Insights new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.