Skip to content

Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01 #31968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 24, 2025
Merged

Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01 #31968

merged 5 commits into from
Feb 24, 2025

Conversation

raresmihai
Copy link
Contributor

Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Add AutomaticZoneRebalancingPolicy to the ResiliencyPolicy for VMSS

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 27, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 27, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute There is no API change compared with the previous version
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=9340c5af09c04f668f9395c8bfeee1fe
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=5e1a621259544ff59a761408a9828d33
.Net Azure.ResourceManager.Compute https://apiview.dev/Assemblies/Review/7fec998c6beb4201bb99c335d06c70fa?revisionId=430b046298bd4a7f97df87a67fa4b1e7

@azure-sdk azure-sdk mentioned this pull request Dec 27, 2024
Closed
@azure-sdk azure-sdk mentioned this pull request Dec 27, 2024
Closed
@raresmihai
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

This was referenced Dec 27, 2024
Closed
Closed
Closed
Closed
@grizzlytheodore grizzlytheodore marked this pull request as ready for review December 31, 2024 03:41
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jan 27, 2025
@grizzlytheodore grizzlytheodore removed the no-recent-activity There has been no recent activity on this issue. label Feb 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Feb 24, 2025
@grizzlytheodore grizzlytheodore merged commit ae5a561 into Azure:feature/cplat-2024-11-01 Feb 24, 2025
21 of 24 checks passed
@grizzlytheodore grizzlytheodore mentioned this pull request Feb 24, 2025
Merged
8 tasks
grizzlytheodore added a commit that referenced this pull request Mar 10, 2025
@grizzlytheodore @haagha
@aleclawlor @Suchintan-microsoft @msdorahu @raresmihai @shahan27 @navya-rao @leonli1224 @hmyan90 @jliusan @hilaryw29 @Avinash-Bondalapati @pr-work
ComputeRP 2024-11-01 (#32787)
09e279b 
* copy last version as 2024-11-01

* update swagger files version references to 2024-11-01

* update version reference in example files

* update readme

* adding x-ms-paths

* adding examples

* Revert "adding x-ms-paths"

This reverts commit b97215c.

* Revert "adding examples"

This reverts commit 88444a3.

* update example for 2024-11-01 (#31092)

Co-authored-by: Alec Lawlor <[email protected]>

* New top-level Virtual Machine property: placement (#31425)

* Added Placement property to vm, alignRegionalDisksToVMZone property to storageProfile

* 2024-11-01

* Review comments

* prettier

* br

* fixes

* Update readme.md

* Update Readme.md

* Update readme.md

* VirtualMachine - BodyTopLevelProperties suppression

* retrigger checks

* Add SkuProfile VMSize Rank to Compute 2024-11-01 API Version (#31519)

* instance mix rank

* link example

* Adding x-ms-paths with expanded properties for VirtualMachineImages_ListWithProperties (#31933)

* comment

* Add x-ms-enum and x-ms-pageable properties

* adding type VirtualMachineImagesWithPropertiesListResult

* Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01 (#31968)

* Add AutomaticZoneRebalancingPolicy part of ResiliencyPolicy to VMSS API V2024-11-01

* Run prettier on virtualMachineScaleSet.json

* Rearrange resiliencyPolicy properties according to PR comment.

* Remove AutomaticExpansionPolicy's minTargetZonalInstanceCount min and max limitations

* Remove expansionPolicy

---------

Co-authored-by: Rares-Mihai Babuta <[email protected]>

* added priortize scale in example and scale in feature (#32024)

Co-authored-by: Shahan Rahman <[email protected]>

* Update Force Delete Description for 2024-11-01 Api Version (#31994)

* update delete operation description

* adding afec details

* update virtual machine json

* moving description to parameter's description and add break tags

---------

Co-authored-by: Navya Rao <[email protected]>

* migrate vm/avset api changes (#31915)

* migrate vm/avset api changes

* adjust according to new change

* changes according to check

* more changes to pass the check

* format

* change description

* rename test file

* fix for test

* more changes for examples and test

* fix lintdiff error

* change from 200 to 204

* add test file

* resolve lint diff

* revert

---------

Co-authored-by: Jiahui Li <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>

* Update ProxyAgentSettings API Format (#32361)

* Check in ProxyAgentSettings updated format

* add suppression

* remove suppression

* restore global mode property

* more on restore gloabl mode property

* fix duplicate name of x-ms-enum

---------

Co-authored-by: judy.liu <[email protected]>

* Updated description for "vmHealth" (#32438)

* Updated description for "vmHealth"

* Update virtualMachine.json

* added ResilientVMDeletionStatus to Get VMScaleSet VM API and List VMScaleSet VMs API. (#32531)

* added ResilientVMDeletionStatus

* fixed prettier issues.

* Fixed XmsEnumValidation error.

* fixed Swagger ModelValidation

* updating network api verison for nwinterfaceConfig (#32618)

Co-authored-by: Prachi Pravin Bhavsar <[email protected]>

* Description updates replacing #32071

* fix modelvalidation and avocado

* Adding examples to VirtualMachineImages_ListWithProperties (#32788)

* comment

* Add x-ms-enum and x-ms-pageable properties

* adding type VirtualMachineImagesWithPropertiesListResult

* adding examples

* fixing error

* fix names

* prettier fix

* Update VM image properties in JSON example

* Update VM image properties in JSON file

* Fix typo in JSON property value.

---------

Co-authored-by: Theodore Chang <[email protected]>

* update new version - fixing mistake

* add type: object

* undo breaking change

* Update virtualMachineScaleSet.json

* fix typo

---------

Co-authored-by: haider agha <[email protected]>
Co-authored-by: Alec Lawlor <[email protected]>
Co-authored-by: Alec Lawlor <[email protected]>
Co-authored-by: Suchintan-microsoft <[email protected]>
Co-authored-by: msdorahu <[email protected]>
Co-authored-by: Haider Agha <[email protected]>
Co-authored-by: Rares Mihai Babuta <[email protected]>
Co-authored-by: Rares-Mihai Babuta <[email protected]>
Co-authored-by: Shahan Rahman <[email protected]>
Co-authored-by: Shahan Rahman <[email protected]>
Co-authored-by: Navya <[email protected]>
Co-authored-by: Navya Rao <[email protected]>
Co-authored-by: jiahi li <[email protected]>
Co-authored-by: Jiahui Li <[email protected]>
Co-authored-by: Huimin Yan <[email protected]>
Co-authored-by: judy.liu <[email protected]>
Co-authored-by: Hilary Wang <[email protected]>
Co-authored-by: Avinash-Bondalapati <[email protected]>
Co-authored-by: pracsb <[email protected]>
Co-authored-by: Prachi Pravin Bhavsar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grizzlytheodore grizzlytheodore grizzlytheodore approved these changes

@Sandido Sandido Awaiting requested review from Sandido

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms

@haagha haagha Awaiting requested review from haagha

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs

@mabhard mabhard Awaiting requested review from mabhard

Assignees
No one assigned
Labels
BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk Compute no-recent-activity There has been no recent activity on this issue. resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raresmihai @grizzlytheodore @azure-sdk @AzureRestAPISpecReview