feat: adding more specific quota errors, and test coverage for the package #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 83.12% 84.49% +1.37%
==========================================
Files 5 6 +1
Lines 237 258 +21
==========================================
+ Hits 197 218 +21
Misses 34 34
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Bryce-Soghigian
changed the title
charliedmcb
reviewed
Nov 22, 2023
charliedmcb
reviewed
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR Does
Subscription Level Quota captures the fact there is a quota error well, but we need more specific quota errors inside of karpenter.
The behavior should differ between TotalRegionalCores subscription level quota, and between a SKU Families quota error.
So now I want to detect them separately.
How was this PR Tested
Unit tests