refine sdk automation tool #23959
Open
refine sdk automation tool #23959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JiaqiZhang-Dev, could you help to review this PR? Thanks |
|
@lirenhe 👌 |
| log.Printf("##[command]Executing go mod tidy in %s\n", packagePath) | ||
| if err = ExecuteGo(packagePath, "mod", "tidy"); err != nil { | ||
| if packageRelativePath != moduleRelativePath { | ||
| // remove go.mod for sub package |
There was a problem hiding this comment.
There are some questions about this operation
- The condition of existing sub package is like this?
service-dir: "sdk/resourcemanager/service_name"
package-dir: "package_name"
module: "github.com/Azure/azure-sdk-for-go/{service-dir}/{package-dir}/subpackage_name" - why was the sub package's go.mod generated? Is it a problem of 'tsp-client init' command?
- Does there has existed these sub package go.mod? how about processing the current existed go.mod for sub package in the repo?
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| log.Printf("Update module definition if v2+...") | ||
| err = UpdateModuleDefinition(packagePath, packageModuleRelativePath, version) | ||
| err = UpdateModuleDefinition(packagePath, packageRelativePath, version) |
There was a problem hiding this comment.
Is there should be the modelPath and moduleRelativePath?
There was a problem hiding this comment.
current impl is kind of a workaround. i separated the module from package since current go code generator does not support namespace in typespec.
| @@ -191,9 +203,6 @@ func (tc TypeSpecConfig) GetModuleName() ([2]string, error) { | |||
| module := (option.(map[string]any))["module"].(string) | |||
| s := strings.Split(module, "/") | |||
| l := len(s) | |||
| if l != 7 { | |||
| return [2]string{}, fmt.Errorf("module is invalid and must be in the format of `github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/{rpName}/{packageName}`") | |||
| } | |||
| if !strings.Contains(s[l-1], "arm") && !strings.Contains(s[l-1], "az") { | |||
There was a problem hiding this comment.
To avoid an array out-of-bounds error, there could be added a length check~
There was a problem hiding this comment.
just leave this pr open. after we have a conclusion about the sub package generation, you could refactor all the generator tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up tasks: