Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only mgmt return error in sdk automation #23989

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

only mgmt return error in sdk automation #23989

wants to merge 3 commits into from

Conversation

JiaqiZhang-Dev
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

tadelesh
tadelesh approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do scenario test before merge.

@tadelesh
Copy link
Member

/check-enforcer override

@tadelesh
Copy link
Member

tadelesh commented Jan 23, 2025 •
edited
Loading

/check-enforcer override

override the check since the change is only for sdk automation. no impact for any service packages.

@JiaqiZhang-Dev
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

lirenhe
lirenhe reviewed Jan 26, 2025
View reviewed changes
eng/tools/generator/cmd/v2/automation/automationCmd.go
if IsManagementPlaneProject(input) {
return err
}
fmt.Println(err)
}

return nil
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we enabled any tests for the go automation tooling?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done some tests in local, and @jliusan also help test by using a swagger and a tspconfig cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@tadelesh tadelesh tadelesh approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiaqiZhang-Dev @tadelesh @lirenhe