APIView Creation from PR for Go #24000
Conversation
chidozieononiwu
commented
Jan 23, 2025
chidozieononiwu
commented
- This adds a step to publish .gosource artifact and trigger call to APIView endpoint for detecting API changes
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
47fbccc to
127671c
Compare
|
/azp run go - aztemplate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
115c5b6 to
4461d43
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
4461d43 to
1cc54b9
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
1cc54b9 to
1caefd1
Compare
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
3 times, most recently
from
d7d3aa0 to
86b795c
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
70fb42e to
02446d7
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
02446d7 to
ff7bf90
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
a5290c1 to
5577a33
Compare
|
/azp run go - aztemplate - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
11 times, most recently
from
56c2dae to
a77e679
Compare
| @@ -101,13 +101,11 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) | |||
| $searchPath = Join-Path $RepoRoot "sdk" | |||
| $pkgFiles = @() | |||
| if ($serviceDirectory) { | |||
| $searchPath = Join-Path $searchPath $serviceDirectory "go.mod" | |||
There was a problem hiding this comment.
Previous code was not doing recursive search when service directory is passed. I think Go has sub modules which contains go.mod and that's probably the reason we don't do Recurse to find package in service directory.
@benbp Can you please confirm if sub module also can have go.mod?
There was a problem hiding this comment.
In most cases the go.mod is not at the service directory level, which is why old logic did not work
| - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml | ||
| parameters: | ||
| ArtifactName: "PackageInfo" |
There was a problem hiding this comment.
Don't we still need old PackageInfo for other EngSys tools?
There was a problem hiding this comment.
I don't think so. All calls to it are from the $(ArtifactStagingDirectory) where it is initially created.
There was a problem hiding this comment.
Actually, It is being downloaded in the go release job
There was a problem hiding this comment.
I don't see it being used though. However, I have added another publish step for PackageInfo artifact.
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
a77e679 to
1704c00
Compare
|
API change check API changes are not detected in this pull request. |
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
5 times, most recently
from
b81ffff to
e98872c
Compare
Changes in Template for testing Update go Language Settings and Detect-Api-Changes test Changes manually Update Go Analyze Step
chidozieononiwu
force-pushed
the
apiView/goPullRequests
branch
from
e98872c to
927475e
Compare
