fix: make it os compatible. #24040
Merged
fix: make it os compatible. #24040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path package methods are used for url and unix specific operation. filepath pacakge methods are used for file system operation and cross platform.
Use filepath.Ext for file system extension.
Gofastasf
requested review from
ArcturusZhang,
lirenhe,
tadelesh,
JiaqiZhang-Dev,
benbp,
weshaggard,
souravgupta-msft,
jhendrixMSFT,
gapra-msft,
vibhansa-msft,
tanyasethi-msft,
chlowell,
richardpark-msft and
RickWinter
as code owners
|
Thank you for your contribution @Gofastasf! We will review the pull request and get back to you soon. |
github-actions
bot
added
Community Contribution
jhendrixMSFT
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Changes to storage has introduced regressions like in #24039
- Update findCoverageFile to match exact file names. - Enhance includePreviewPredicate for exact names. - Direct file checking of go.mod. - Removed hardcoded previewSubdir const.
Gofastasf
force-pushed
the
fix/replace-strings.Contains
branch
from
4e0941a to
ac60429
Compare
|
@jhendrixMSFT Hey resolved the CI issue. I guess its ready to get merged? |
|
Do we still need #24039? |
|
@jhendrixMSFT Closed #24039. |
jhendrixMSFT
approved these changes
Feb 4, 2025
JiaqiZhang-Dev
approved these changes
Feb 5, 2025
|
@benbp Hey can you checkout this PR ? I think its ready to get merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove strings.Contains to:
Remove path packge methods: