[azcore/tracing] Add propagator and link wrapper #24069
Open
+280
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenychen
requested review from
RickWinter,
chlowell,
jhendrixMSFT and
richardpark-msft
as code owners
|
Thank you for your contribution @karenychen! We will review the pull request and get back to you soon. |
github-actions
bot
added
Azure.Core
Community Contribution
karenychen
commented
Feb 7, 2025
There was a problem hiding this comment.
@jhendrixMSFT Since we haven't added context propagation in the http requests, I left the newPropagatorFn here to nil. But please do let me know if you prefer it to be set :)
karenychen
commented
Feb 7, 2025
| // TraceStateImpl contains the implementation for TraceState. | ||
| type TraceStateImpl struct { | ||
| // String contains the implementation for the TraceState.String method. | ||
| String func() string |
There was a problem hiding this comment.
There are more methods to the Otel implementation for TraceState, but String() is all we need at the moment to parse it to use the ParseTraceState() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Propagator and Links to
azcore/tracing. This will allow context propagation and span links in the SDK.