Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always do beta release for first release & refactor generator #24070

Merged
merged 6 commits into from
Feb 10, 2025
Merged

always do beta release for first release & refactor generator #24070

merged 6 commits into from
Feb 10, 2025

Conversation

JiaqiZhang-Dev
Copy link
Member

@JiaqiZhang-Dev JiaqiZhang-Dev commented Feb 7, 2025 •
edited
Loading

resolve: #23877

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@JiaqiZhang-Dev
Copy link
Member Author

related issue: #23877 (comment)

@tadelesh
Copy link
Member

tadelesh commented Feb 7, 2025

@JiaqiZhang-Dev you could add resolve: #23877 in the pr description. then it will link this pr with that issue and close that issue when this pr merge.

tadelesh
tadelesh approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one optimization suggestion. you could decide to do that in another refactor pr.

eng/tools/generator/cmd/v2/common/generation.go Show resolved Hide resolved
@JiaqiZhang-Dev JiaqiZhang-Dev merged commit 2f4e20b into main Feb 10, 2025
44 checks passed
@JiaqiZhang-Dev JiaqiZhang-Dev deleted the generator_first_release_label branch February 10, 2025 09:17
@JiaqiZhang-Dev JiaqiZhang-Dev restored the generator_first_release_label branch February 10, 2025 13:22
@JiaqiZhang-Dev JiaqiZhang-Dev deleted the generator_first_release_label branch February 10, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mgmt] always do beta release for first release
2 participants
@JiaqiZhang-Dev @tadelesh