-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Javadoc of premium SDK for azure-resourcemanager #43638
Open
v-hongli1
wants to merge
3
commits into
Azure:main
Choose a base branch
from
v-hongli1:update-Javadoc-of-premium-SDK-azure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Javadoc of premium SDK for azure-resourcemanager #43638
v-hongli1
wants to merge
3
commits into
Azure:main
from
v-hongli1:update-Javadoc-of-premium-SDK-azure
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
This issue is related to a management-plane library.
label
Dec 26, 2024
API change check API changes are not detected in this pull request. |
v-hongli1
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
December 27, 2024 09:47
Comment on lines
+1186
to
+1208
/** | ||
* Gets entry point to manage compute galleries. | ||
* | ||
* @return entry point to manage compute galleries. | ||
*/ | ||
public Galleries galleries() { | ||
return this.computeManager.galleries(); | ||
} | ||
|
||
/** @return entry point to manage compute gallery images. */ | ||
/** | ||
* Gets entry point to manage compute gallery images. | ||
* | ||
* @return entry point to manage compute gallery images. | ||
*/ | ||
public GalleryImages galleryImages() { | ||
return this.computeManager.galleryImages(); | ||
} | ||
|
||
/** @return entry point to manage compute gallery image versions. */ | ||
/** | ||
* Gets entry point to manage compute gallery image versions. | ||
* | ||
* @return entry point to manage compute gallery image versions. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, consistency, manage
-> managing
Comment on lines
+1282
to
+1286
/** | ||
* Gets entry point to tag management management. | ||
* | ||
* @return entry point to tag management management | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/** | |
* Gets entry point to tag management management. | |
* | |
* @return entry point to tag management management | |
*/ | |
/** | |
* Gets entry point to tag management. | |
* | |
* @return entry point to tag management | |
*/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines