Merge 7f8247e into ab06e98

Azure · Nov 7, 2024 · e7fcb2d · e7fcb2d
2 parents ab06e98 + 7f8247e
commit e7fcb2d
Show file tree

Hide file tree

Showing 5 changed files with 79 additions and 5 deletions.
diff --git a/eng/pipelines/templates/stages/archetype-js-release.yml b/eng/pipelines/templates/stages/archetype-js-release.yml
@@ -94,7 +94,6 @@ stages:
                               condition: succeeded()
                             - template: /eng/pipelines/templates/steps/npm-release-task.yml
                               parameters:
-                                ArtifactName: ${{parameters.ArtifactName}}
                                 Artifact: ${{artifact}}
                                 Registry: ${{parameters.Registry}}
                                 PathToArtifacts: $(Pipeline.Workspace)/${{parameters.ArtifactName}}/${{artifact.name}}
@@ -258,7 +257,6 @@ stages:
                     displayName: Detecting package archive_${{artifact.name}}
                   - template: /eng/pipelines/templates/steps/npm-release-task.yml
                     parameters:
-                      ArtifactName: ${{parameters.ArtifactName}}
                       Artifact: ${{artifact}}
                       Registry: ${{parameters.Registry}}
                       PathToArtifacts: $(Pipeline.Workspace)/${{parameters.ArtifactName}}/${{artifact.name}}

diff --git a/eng/pipelines/templates/stages/archetype-sdk-client.yml b/eng/pipelines/templates/stages/archetype-sdk-client.yml
@@ -57,7 +57,7 @@ extends:
               Artifacts: ${{ parameters.Artifacts }}
               ${{ if eq(parameters.ServiceDirectory, 'template') }}:
                 TestPipeline: true
-              RunUnitTests: ${{ parameters.RunUnitTests }}
+              RunUnitTests: false
               MatrixConfigs:
                 - ${{ each config in parameters.MatrixConfigs }}:
                     - ${{ config }}

diff --git a/eng/pipelines/templates/stages/partner-release.yml b/eng/pipelines/templates/stages/partner-release.yml
@@ -58,7 +58,6 @@ extends:
 
           - template: /eng/pipelines/templates/steps/npm-release-task.yml
             parameters:
-              ArtifactName: Partner Drop
               Artifact: 
                 name: Partner Drop
                 path: $(Artifacts)

diff --git a/eng/pipelines/templates/steps/npm-release-task.yml b/eng/pipelines/templates/steps/npm-release-task.yml
@@ -1,5 +1,4 @@
 parameters:
-  ArtifactName: ''
   Artifact: {}
   Registry: ''
   PathToArtifacts: ''
@@ -10,6 +9,27 @@ steps:
   - template: /eng/common/pipelines/templates/steps/set-default-branch.yml
 
   - ${{ if eq(parameters.Registry, 'https://registry.npmjs.org/') }}:
+    - pwsh: |
+        Set-PSDebug -Trace 1
+        $tarFile = (Get-ChildItem -Path "${{parameters.PathToArtifacts}}/*.tgz").FullName
+        $tempDir = "$(System.DefaultWorkingDirectory)/temp_decompress"
+        New-Item -ItemType Directory -Force -Path $tempDir
+        tar -xzf $tarFile -C $tempDir
+        $packageJsonDir = "$tempDir\package\package.json"
+        echo "##vso[task.setvariable variable=PackageJsonDir]$packageJsonDir"
+        $pkg = Get-Content -Raw "$packageJsonDir" | ConvertFrom-Json
+        $packageName = $pkg.Name
+        $packageVersion = $pkg.Version
+        $packageProps = npm view $packageName -json | ConvertFrom-Json
+        $originalTags = $packageProps.'dist-tags' | ConvertTo-Json -Compress
+        echo "##vso[task.setvariable variable=OriginalTags]$originalTags"
+        echo "##vso[task.setvariable variable=IntendedTagVersion]$packageVersion"
+        Write-Host "PackageProps: $packageProps"
+        Write-Host "packageName: $packageName"
+        Write-Host "originalTags: $originalTags"
+        Write-Host "packageVersion: $packageVersion"
+      displayName: Get original tags
+
     - task: EsrpRelease@7
       inputs:
         displayName: 'Publish ${{parameters.Artifact.name}} to ESRP'
@@ -28,6 +48,14 @@ steps:
         DomainTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
         productstate: ${{parameters.Tag}}
 
+    - task: Powershell@2
+      displayName: Verify package tags
+      inputs:
+        targetType: filePath
+        filePath: eng/scripts/verify-npm-tags.ps1
+        arguments: -originalDistTags '$(OriginalTags)' -intendedTag ${{parameters.Tag}} -intendedTagVersion '$(IntendedTagVersion)' -packageJson $(PackageJsonDir)
+        pwsh: true
+
     - ${{ if ne(parameters.AdditionalTag, '') }}:
       - task: PowerShell@2
         displayName: Add Additional Tag

diff --git a/eng/scripts/verify-npm-tags.ps1 b/eng/scripts/verify-npm-tags.ps1
@@ -0,0 +1,49 @@
+param (
+  [Parameter(mandatory = $true)]
+  $originalDistTags,
+  [Parameter(mandatory = $true)]
+  $intendedTag,
+  [Parameter(mandatory = $true)]
+  $intendedTagVersion,
+  [Parameter(mandatory = $true)]
+  $packageJson
+)
+
+# TODO: delete testing comments below
+#'@azure/eventhubs-checkpointstore-table' alpha, no beta, no GA
+#'@azure/openai' alpha, beta, no GA
+#'@azure/video-indexer-widgets' no alpha, no beta, GA
+#'@azure/template' alpha, beta, GA
+#$pkgProps.PackageId
+
+$ErrorActionPreference = 'Stop'
+$PSNativeCommandUseErrorActionPreference = $true
+
+$pkg = Get-Content -Raw $packageJson | ConvertFrom-Json
+$packageName = $pkg.Name
+
+Write-Host "Verify npm tag versions for package $packageName"
+
+$parsedOriginalDistTags = $originalDistTags | ConvertFrom-Json
+
+$npmPkgProp = npm view $packageName --json | ConvertFrom-Json
+$packageDistTags = $npmPkgProp."dist-tags"
+Write-Host "Current dist-tag: $packageDistTags"
+
+Write-Host "parsedOriginalDistTags: $parsedOriginalDistTags"
+Write-Host "packageDistTags: $packageDistTags"
+Write-Host "intendedTag: $($packageDistTags."$intendedTag")"
+Write-Host "intendedTagVersion: $intendedTagVersion"
+
+if ($packageDistTags."$intendedTag" -ne $intendedTagVersion) {
+  Write-Warning "Tag not correctly set, current $intendedTag tag is version $($packageDistTags."$intendedTag") instead of $intendedTagVersion."
+  $correctDistTags = $parsedOriginalDistTags
+  $correctDistTags."$intendedTag" = $intendedTagVersion
+  foreach($tag in $correctDistTags.PSObject.Properties) {
+    Write-Host "npm dist-tag add $packageName@$($tag.value) $tag.Name"
+    npm dist-tag add $packageName@$tag.value $tag.Name
+  }
+  $npmPkgProp = npm view $packageName --json | ConvertFrom-Json
+  $packageDistTags = $npmPkgProp."dist-tags"
+  Write-Host "Corrected dist tags to: $packageDistTags"
+}