Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Generate-code-from-TypeSpec.md #32332

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Update Generate-code-from-TypeSpec.md #32332

merged 4 commits into from
Jan 8, 2025

Conversation

kazrael2119
Copy link
Contributor

No description provided.

@wanlwanl
Copy link
Member

@raych1 please review

@raych1
Copy link
Member

raych1 commented Jan 6, 2025

@kazrael2119 , other than the comment from @lirenhe , the remained part looks good to me.

Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha
Copy link
Member

qiaozha commented Jan 8, 2025

I will merge this first, but feel free to let me know if you have any concerns @jeremymeng and @lirenhe

@qiaozha qiaozha merged commit 722f7ea into main Jan 8, 2025
14 checks passed
@qiaozha qiaozha deleted the doc1 branch January 8, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants