-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[mgmt] migrate mgmt package to esm 10 #32370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8ccf30a
Migration: Update package.json, tsconfig.json, and api-extractor.json
kazrael2119 4104624
Migration: Update test config
kazrael2119 41c9b39
Migration: Clean up files
kazrael2119 0d3ac99
Migration: Apply codemod: "fixSourceFile"
kazrael2119 7919382
Migration: Apply codemod: "fixTestingImports"
kazrael2119 a5ed6c3
Migration: Apply codemod: "replaceAssertIsRejected"
kazrael2119 290c8f6
Migration: Apply codemod: "replaceSinonStub"
kazrael2119 5f5b6be
Migration: Apply codemod: "addViHelper"
kazrael2119 ab571a0
Migration: Apply codemod: "replaceSupportTracing"
kazrael2119 6d1feca
Migration: Apply codemod: "replaceTestUtils"
kazrael2119 bdb2a6c
Migration: rushx format
kazrael2119 ac9877d
update
kazrael2119 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,22 +24,22 @@ | |
"isomorphic" | ||
], | ||
"license": "MIT", | ||
"main": "./dist/index.js", | ||
"module": "./dist-esm/src/index.js", | ||
"types": "./types/arm-datadog.d.ts", | ||
"main": "./dist/commonjs/index.js", | ||
"module": "./dist/esm/index.js", | ||
"types": "./dist/commonjs/index.d.ts", | ||
"devDependencies": { | ||
"@azure-tools/test-credential": "^1.0.0", | ||
"@azure-tools/test-recorder": "^3.0.0", | ||
"@azure-tools/test-credential": "^2.0.0", | ||
"@azure-tools/test-recorder": "^4.1.0", | ||
"@azure-tools/test-utils-vitest": "^1.0.0", | ||
"@azure/dev-tool": "^1.0.0", | ||
"@azure/identity": "^4.0.1", | ||
"@types/chai": "^4.2.8", | ||
"@types/mocha": "^10.0.0", | ||
"@types/node": "^18.0.0", | ||
"chai": "^4.2.0", | ||
"@vitest/browser": "^2.1.8", | ||
"@vitest/coverage-istanbul": "^2.1.8", | ||
"dotenv": "^16.0.0", | ||
"mocha": "^11.0.2", | ||
"ts-node": "^10.0.0", | ||
"typescript": "~5.7.2" | ||
"playwright": "^1.49.1", | ||
"typescript": "~5.7.2", | ||
"vitest": "^2.1.8" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
|
@@ -49,24 +49,14 @@ | |
"url": "https://github.com/Azure/azure-sdk-for-js/issues" | ||
}, | ||
"files": [ | ||
"dist/**/*.js", | ||
"dist/**/*.js.map", | ||
"dist/**/*.d.ts", | ||
"dist/**/*.d.ts.map", | ||
"dist-esm/**/*.js", | ||
"dist-esm/**/*.js.map", | ||
"dist-esm/**/*.d.ts", | ||
"dist-esm/**/*.d.ts.map", | ||
"src/**/*.ts", | ||
"dist/", | ||
"README.md", | ||
"LICENSE", | ||
"tsconfig.json", | ||
"review/*", | ||
"CHANGELOG.md", | ||
"types/*" | ||
"review/", | ||
"CHANGELOG.md" | ||
], | ||
"scripts": { | ||
"build": "npm run clean && tsc && dev-tool run bundle && npm run minify && dev-tool run vendored mkdirp ./review && npm run extract-api", | ||
"build": "npm run clean && dev-tool run build-package && dev-tool run vendored mkdirp ./review && dev-tool run extract-api", | ||
"build:browser": "echo skipped", | ||
"build:node": "echo skipped", | ||
"build:samples": "echo skipped.", | ||
|
@@ -78,7 +68,7 @@ | |
"format": "echo skipped", | ||
"integration-test": "npm run integration-test:node && npm run integration-test:browser", | ||
"integration-test:browser": "echo skipped", | ||
"integration-test:node": "dev-tool run test:node-ts-input -- --timeout 1200000 'test/*.ts'", | ||
"integration-test:node": "dev-tool run test:vitest --esm", | ||
"lint": "echo skipped", | ||
"minify": "dev-tool run vendored uglifyjs -c -m --comments --source-map \"content='./dist/index.js.map'\" -o ./dist/index.min.js ./dist/index.js", | ||
"pack": "npm pack 2>&1", | ||
|
@@ -87,8 +77,8 @@ | |
"test:browser": "echo skipped", | ||
"test:node": "echo skipped", | ||
"unit-test": "npm run unit-test:node && npm run unit-test:browser", | ||
"unit-test:browser": "echo skipped", | ||
"unit-test:node": "dev-tool run vendored cross-env TEST_MODE=playback npm run integration-test:node", | ||
"unit-test:browser": "npm run clean && dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser", | ||
"unit-test:node": "dev-tool run test:vitest", | ||
"update-snippets": "echo skipped" | ||
}, | ||
"sideEffects": false, | ||
|
@@ -109,5 +99,45 @@ | |
], | ||
"disableDocsMs": true, | ||
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-datadog?view=azure-node-preview" | ||
}, | ||
"type": "module", | ||
"tshy": { | ||
"project": "./tsconfig.src.json", | ||
"exports": { | ||
"./package.json": "./package.json", | ||
".": "./src/index.ts" | ||
}, | ||
"dialects": [ | ||
"esm", | ||
"commonjs" | ||
], | ||
"esmDialects": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we shipping for React-Native and Browser support? If not, please remove the |
||
"browser", | ||
"react-native" | ||
], | ||
"selfLink": false | ||
}, | ||
"browser": "./dist/browser/index.js", | ||
"react-native": "./dist/react-native/index.js", | ||
"exports": { | ||
"./package.json": "./package.json", | ||
".": { | ||
"browser": { | ||
"types": "./dist/browser/index.d.ts", | ||
"default": "./dist/browser/index.js" | ||
}, | ||
"react-native": { | ||
"types": "./dist/react-native/index.d.ts", | ||
"default": "./dist/react-native/index.js" | ||
}, | ||
"import": { | ||
"types": "./dist/esm/index.d.ts", | ||
"default": "./dist/esm/index.js" | ||
}, | ||
"require": { | ||
"types": "./dist/commonjs/index.d.ts", | ||
"default": "./dist/commonjs/index.js" | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we revert this ?