Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-tables] Add options to submitTransaction #32384

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Dec 30, 2024

Packages impacted by this PR

@azure/data-tables

Issues associated with this PR

Fixes #28624

Describe the problem that is addressed by this PR

submitTransaction on TableClient didn't allow for passing request-level options, such as an AbortSignal to cancel the request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/data-tables

@xirzec
Copy link
Member Author

xirzec commented Jan 2, 2025

Disabling the lint check for the options name until #31290 is addressed

@xirzec xirzec enabled auto-merge (squash) January 2, 2025 22:00
@xirzec xirzec disabled auto-merge January 2, 2025 22:00
@xirzec xirzec merged commit 78dd272 into Azure:main Jan 2, 2025
14 checks passed
xirzec added a commit that referenced this pull request Jan 2, 2025
### Packages impacted by this PR

`@azure/data-tables`

### Issues associated with this PR

Fixes #28624

### Describe the problem that is addressed by this PR

`submitTransaction` on `TableClient` didn't allow for passing
request-level options, such as an `AbortSignal` to cancel the request.
@xirzec xirzec deleted the submitTransactionFix branch January 2, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableClient.submitTransaction and TableTransaction do not expose OperationOptions
4 participants