[engsys] Fix rush-runner #32392
Merged
[engsys] Fix rush-runner #32392
+14
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
|
API change check API changes are not detected in this pull request. |
jeremymeng
approved these changes
Dec 31, 2024
sdk/eventgrid/eventgrid-namespaces/samples/v1/javascript/namespaceActivities.js
Show resolved
Hide resolved
|
communication-sms unit-tests failing as expected |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
All packages using CI
Describe the problem that is addressed by this PR
@qiaozha noticed that tests were no longer failing the build. After some investigation, I realized that PR #32148 introduced a regression with how the process exitCode was being propagated. Previously, we were setting it globally via
process.exitCodewhere we spawn the node process, but this was refactored to use return codes.However, the return code was never used when the task was anything except
lintandcheck-formatmeaning that build and test operations did not report failure correctly.In the future, we should figure out a better way to abstract and test this script's return codes, but I'd like to get a fix in to prevent bad PRs from being merged in the meantime.