Sofiar/fix aad tests in pipeline #35831
Conversation
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… sofiar/Fix_aad_tests_in_pipeline
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…nvironments and improve Node.js checks
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… for Azure communication resources
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…missing environment variables
|
/azp run js - communication-phone-numbers - tests |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… sofiar/Fix_aad_tests_in_pipeline
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| import { isNodeLike } from "@azure/core-util"; | ||
| import { createTestCredential } from "@azure-tools/test-credential"; | ||
| import { createMSUserAgentPolicy } from "./msUserAgentPolicy.js"; | ||
| import { createOperationLocationFixPolicy } from "./operationLocationFixPolicy.js"; | ||
| import { DefaultAzureCredential } from "@azure/identity"; | ||
| let fetch: typeof globalThis.fetch; |
There was a problem hiding this comment.
fetch is available in NodeJS v20+ so we shouldn't need node-fetch. Did you get errors when using it without node-fetch?
There was a problem hiding this comment.
Haven't tried this, but will do!
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| import { isNodeLike } from "@azure/core-util"; | ||
| import { createTestCredential } from "@azure-tools/test-credential"; | ||
| import { createMSUserAgentPolicy } from "./msUserAgentPolicy.js"; | ||
| import { createOperationLocationFixPolicy } from "./operationLocationFixPolicy.js"; | ||
| import { DefaultAzureCredential } from "@azure/identity"; | ||
| let fetch: typeof globalThis.fetch; | ||
| let crypto: typeof import("crypto"); |
There was a problem hiding this comment.
Use randomUUID from core-util instead. example:
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists