-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Identity] Updated proper claims encoding #35855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where AzureCliCredential
, AzurePowerShellCredential
, and AzureDeveloperCliCredential
were not properly encoding claims challenges as base64 strings before including them in command line arguments.
- Updated all three credential implementations to encode claims values using
btoa()
before passing them to CLI commands - Updated corresponding test files to expect base64-encoded claims in command assertions
- Added changelog entry documenting the bug fix
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
sdk/identity/identity/src/credentials/azureCliCredential.ts |
Added base64 encoding of claims challenges before constructing CLI commands |
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts |
Added base64 encoding of claims challenges before constructing PowerShell commands |
sdk/identity/identity/src/credentials/azureDeveloperCliCredential.ts |
Added base64 encoding of claims challenges before constructing Azure Developer CLI commands |
sdk/identity/identity/test/internal/node/azureCliCredential.spec.ts |
Updated test assertions to expect base64-encoded claims in CLI commands |
sdk/identity/identity/test/internal/node/azurePowerShellCredential.spec.ts |
Updated test assertions to expect base64-encoded claims in PowerShell commands |
sdk/identity/identity/test/internal/node/azureDeveloperCliCredential.spec.ts |
Updated test assertions to expect base64-encoded claims in Azure Developer CLI commands |
sdk/identity/identity/CHANGELOG.md |
Added changelog entry documenting the claims encoding bug fix |
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists