Skip to content

Conversation

minhanh-phan
Copy link
Member

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@minhanh-phan minhanh-phan marked this pull request as ready for review September 8, 2025 16:55
@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where AzureCliCredential, AzurePowerShellCredential, and AzureDeveloperCliCredential were not properly encoding claims challenges as base64 strings before including them in command line arguments.

  • Updated all three credential implementations to encode claims values using btoa() before passing them to CLI commands
  • Updated corresponding test files to expect base64-encoded claims in command assertions
  • Added changelog entry documenting the bug fix

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/identity/identity/src/credentials/azureCliCredential.ts Added base64 encoding of claims challenges before constructing CLI commands
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts Added base64 encoding of claims challenges before constructing PowerShell commands
sdk/identity/identity/src/credentials/azureDeveloperCliCredential.ts Added base64 encoding of claims challenges before constructing Azure Developer CLI commands
sdk/identity/identity/test/internal/node/azureCliCredential.spec.ts Updated test assertions to expect base64-encoded claims in CLI commands
sdk/identity/identity/test/internal/node/azurePowerShellCredential.spec.ts Updated test assertions to expect base64-encoded claims in PowerShell commands
sdk/identity/identity/test/internal/node/azureDeveloperCliCredential.spec.ts Updated test assertions to expect base64-encoded claims in Azure Developer CLI commands
sdk/identity/identity/CHANGELOG.md Added changelog entry documenting the claims encoding bug fix

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Sep 8, 2025
@minhanh-phan minhanh-phan enabled auto-merge (squash) September 8, 2025 18:16
@minhanh-phan minhanh-phan merged commit a59f0b7 into Azure:main Sep 8, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Identity SDK Improvements Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants