Fixing review comments

Azure · Aug 22, 2024 · 8a75f5b · 8a75f5b
1 parent cc760dc
commit 8a75f5b
Show file tree

Hide file tree

Showing 7 changed files with 41 additions and 30 deletions.
diff --git a/...sourceManager.MachineLearning/api/Azure.ResourceManager.MachineLearning.netstandard2.0.cs b/...sourceManager.MachineLearning/api/Azure.ResourceManager.MachineLearning.netstandard2.0.cs
@@ -2934,7 +2934,7 @@ public static partial class ArmMachineLearningModelFactory
         public static Azure.ResourceManager.MachineLearning.Models.OneLakeDatastore OneLakeDatastore(string description = null, System.Collections.Generic.IDictionary<string, string> properties = null, System.Collections.Generic.IDictionary<string, string> tags = null, Azure.ResourceManager.MachineLearning.Models.MachineLearningDatastoreCredentials credentials = null, bool? isDefault = default(bool?), Azure.ResourceManager.MachineLearning.Models.OneLakeArtifact artifact = null, string endpoint = null, string oneLakeWorkspaceName = null, Azure.ResourceManager.MachineLearning.Models.MachineLearningServiceDataAccessAuthIdentity? serviceDataAccessAuthIdentity = default(Azure.ResourceManager.MachineLearning.Models.MachineLearningServiceDataAccessAuthIdentity?)) { throw null; }
         public static Azure.ResourceManager.MachineLearning.Models.OpenAIEndpointDeploymentResourceProperties OpenAIEndpointDeploymentResourceProperties(string failureReason = null, Azure.ResourceManager.MachineLearning.Models.DefaultResourceProvisioningState? provisioningState = default(Azure.ResourceManager.MachineLearning.Models.DefaultResourceProvisioningState?), Azure.ResourceManager.MachineLearning.Models.EndpointDeploymentModel model = null, string raiPolicyName = null, Azure.ResourceManager.MachineLearning.Models.DeploymentModelVersionUpgradeOption? versionUpgradeOption = default(Azure.ResourceManager.MachineLearning.Models.DeploymentModelVersionUpgradeOption?)) { throw null; }
         public static Azure.ResourceManager.MachineLearning.Models.OpenAIEndpointResourceProperties OpenAIEndpointResourceProperties(Azure.Core.ResourceIdentifier associatedResourceId = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.MachineLearning.EndpointDeploymentResourcePropertiesBasicResourceData> deployments = null, System.Uri endpointUri = null, string failureReason = null, Azure.Core.AzureLocation? location = default(Azure.Core.AzureLocation?), string name = null, Azure.ResourceManager.MachineLearning.Models.DefaultResourceProvisioningState? provisioningState = default(Azure.ResourceManager.MachineLearning.Models.DefaultResourceProvisioningState?), bool? shouldCreateAiServicesEndpoint = default(bool?)) { throw null; }
-        public static Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus OSPatchingStatus(Azure.ResourceManager.MachineLearning.Models.PatchStatus? patchStatus = default(Azure.ResourceManager.MachineLearning.Models.PatchStatus?), string latestPatchTime = null, bool? rebootPending = default(bool?), string scheduledRebootTime = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.MachineLearning.Models.MachineLearningError> osPatchingErrors = null) { throw null; }
+        public static Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus OSPatchingStatus(Azure.ResourceManager.MachineLearning.Models.PatchStatus? patchStatus = default(Azure.ResourceManager.MachineLearning.Models.PatchStatus?), System.DateTimeOffset? latestPatchOn = default(System.DateTimeOffset?), bool? rebootPending = default(bool?), System.DateTimeOffset? scheduledRebootOn = default(System.DateTimeOffset?), System.Collections.Generic.IEnumerable<Azure.ResourceManager.MachineLearning.Models.MachineLearningError> osPatchingErrors = null) { throw null; }
         public static Azure.ResourceManager.MachineLearning.Models.PendingUploadResponseDto PendingUploadResponseDto(Azure.ResourceManager.MachineLearning.Models.BlobReferenceForConsumptionDto blobReferenceForConsumption = null, string pendingUploadId = null, Azure.ResourceManager.MachineLearning.Models.PendingUploadType? pendingUploadType = default(Azure.ResourceManager.MachineLearning.Models.PendingUploadType?)) { throw null; }
         public static Azure.ResourceManager.MachineLearning.Models.PrivateEndpointBase PrivateEndpointBase(Azure.Core.ResourceIdentifier id = null) { throw null; }
         public static Azure.ResourceManager.MachineLearning.Models.PrivateEndpointOutboundRule PrivateEndpointOutboundRule(Azure.ResourceManager.MachineLearning.Models.OutboundRuleCategory? category = default(Azure.ResourceManager.MachineLearning.Models.OutboundRuleCategory?), System.Collections.Generic.IEnumerable<string> parentRuleNames = null, Azure.ResourceManager.MachineLearning.Models.OutboundRuleStatus? status = default(Azure.ResourceManager.MachineLearning.Models.OutboundRuleStatus?), Azure.ResourceManager.MachineLearning.Models.PrivateEndpointDestination destination = null, System.Collections.Generic.IEnumerable<string> fqdns = null) { throw null; }
@@ -10013,11 +10013,11 @@ public OpenAIEndpointResourceProperties() { }
     public partial class OSPatchingStatus : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus>
     {
         internal OSPatchingStatus() { }
-        public string LatestPatchTime { get { throw null; } }
+        public System.DateTimeOffset? LatestPatchOn { get { throw null; } }
         public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.MachineLearning.Models.MachineLearningError> OSPatchingErrors { get { throw null; } }
         public Azure.ResourceManager.MachineLearning.Models.PatchStatus? PatchStatus { get { throw null; } }
         public bool? RebootPending { get { throw null; } }
-        public string ScheduledRebootTime { get { throw null; } }
+        public System.DateTimeOffset? ScheduledRebootOn { get { throw null; } }
         Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
         void System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
         Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MachineLearning.Models.OSPatchingStatus>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
@@ -10564,8 +10564,8 @@ public SecretExpiry() { }
     public partial class ServerlessComputeSettings : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings>
     {
         public ServerlessComputeSettings() { }
+        public bool? HasNoPublicIP { get { throw null; } set { } }
         public Azure.Core.ResourceIdentifier ServerlessComputeCustomSubnet { get { throw null; } set { } }
-        public bool? ServerlessComputeNoPublicIP { get { throw null; } set { } }
         Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
         void System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
         Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MachineLearning.Models.ServerlessComputeSettings>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

diff --git a/...ces/Azure.ResourceManager.MachineLearning/src/Generated/ArmMachineLearningModelFactory.cs b/...ces/Azure.ResourceManager.MachineLearning/src/Generated/ArmMachineLearningModelFactory.cs
diff --git a/...re.ResourceManager.MachineLearning/src/Generated/Models/OSPatchingStatus.Serialization.cs b/...re.ResourceManager.MachineLearning/src/Generated/Models/OSPatchingStatus.Serialization.cs
diff --git a/...ngservices/Azure.ResourceManager.MachineLearning/src/Generated/Models/OSPatchingStatus.cs b/...ngservices/Azure.ResourceManager.MachineLearning/src/Generated/Models/OSPatchingStatus.cs
diff --git a/...ceManager.MachineLearning/src/Generated/Models/ServerlessComputeSettings.Serialization.cs b/...ceManager.MachineLearning/src/Generated/Models/ServerlessComputeSettings.Serialization.cs
diff --git a/...s/Azure.ResourceManager.MachineLearning/src/Generated/Models/ServerlessComputeSettings.cs b/...s/Azure.ResourceManager.MachineLearning/src/Generated/Models/ServerlessComputeSettings.cs
diff --git a/sdk/machinelearningservices/Azure.ResourceManager.MachineLearning/src/autorest.md b/sdk/machinelearningservices/Azure.ResourceManager.MachineLearning/src/autorest.md
@@ -518,6 +518,9 @@ rename-mapping:
   StatusMessageLevel: JobStatusMessageLevel
   ImageType.azureml: AzureML
   ProtectionLevel: IntellectualProtectionLevel
+  OsPatchingStatus.latestPatchTime: -|date-time
+  OsPatchingStatus.scheduledRebootTime: -|date-time
+  ServerlessComputeSettings.serverlessComputeNoPublicIP : HasNoPublicIP
 
 suppress-abstract-base-class:
 - MachineLearningJobProperties