-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 1es releasejob for deployments #48555
base: main
Are you sure you want to change the base?
Conversation
4680d20
to
ffe84e1
Compare
outputParentDirectory: '$(Pipeline.Workspace)' | ||
outputs: | ||
- output: nuget | ||
displayName: 'Publish ${{artifact.name}} package to NuGet.org' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit weirded out by the output artifacts used here, as historically I believe they were added to reduce the amount of generated YML. We should try a build of storage
or comunication
release (just up to triggering the release) to ensure that we don't hit max yml size without having this output inlined in the templatecontext.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output artifacts allow you to compress your injected SDL steps by combining all of the scans across all of your outputs. This is in contract to inline output tasks like 1ES.PublishNuget
or 1ES.PublishArtifact
that will inject all of the sdl steps per inlined task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The amount of YML doesn't really change. We were declaring 2 job outputs per artifact, and now we're declaring 2 publish tasks per artifact.
29c44ac
to
b0c179e
Compare
deployment:
step for package deployment job