Skip to content

Commit

Permalink
Support credential-less fileshare datastore (#36392)
Browse files Browse the repository at this point in the history
* support credential less file datastore via sdk/cli

* update changelog

* update docstring
  • Loading branch information
PratibhaShrivastav18 authored Jul 18, 2024
1 parent 4d425f5 commit f8a2115
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions sdk/ml/azure-ai-ml/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bugs Fixed
- Workspace update no longer broken for older workspaces due to deprecated tags.
- Support credential-less fileshare datastore

## 1.18.0 (2024-07-09)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class AzureFileSchema(AzureStorageSchema):
[
NestedField(AccountKeySchema),
NestedField(SasTokenSchema),
],
required=True,
NestedField(NoneCredentialsSchema),
]
)

@post_load
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class AzureFileDatastore(Datastore):
:type protocol: str
:param properties: The asset property dictionary.
:type properties: dict[str, str]
:param credentials: Credentials to use for Azure ML workspace to connect to the storage.
:param credentials: Credentials to use for Azure ML workspace to connect to the storage. Defaults to None.
:type credentials: Union[~azure.ai.ml.entities.AccountKeyConfiguration,
~azure.ai.ml.entities.SasTokenConfiguration]
:param kwargs: A dictionary of additional configuration parameters.
Expand All @@ -67,7 +67,7 @@ def __init__(
endpoint: str = _get_storage_endpoint_from_metadata(),
protocol: str = HTTPS,
properties: Optional[Dict] = None,
credentials: Union[AccountKeyConfiguration, SasTokenConfiguration],
credentials: Optional[Union[AccountKeyConfiguration, SasTokenConfiguration]] = None,
**kwargs: Any
):
kwargs[TYPE] = DatastoreType.AZURE_FILE
Expand Down

0 comments on commit f8a2115

Please sign in to comment.