-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip breaking change detection in release pipeline #36370
Comments
@catalinaperalta |
The tool is scoped to run within a specific sdk directory. Let me know if that's not what you meant |
@msyyc I'm thinking we could probably suppress all change reports for a specific library but you wont see what the breaking changes are for that library in the pipeline. Or do you want the pipeline not to block on the breaking changes check? I think the pipeline configuration should be changed in that case. |
@catalinaperalta I find the way to disable breaking change: azure-sdk-for-python/eng/pipelines/templates/steps/run_breaking_changes.yml Lines 12 to 24 in 14dd582
Skip.BreakingChanges as true then this step shall be skipped.Let me check it and if it works, I will close this issue. |
@msyyc did your solution work? |
I will try it after #36601 merged |
We plan to adopt breaking changes tool when generating SDK so that we could recognize potential SDK breakings in advance. However, when open it for Mgmt SDK, it blocks SDK release so I have to revert it in #36104.
I understand one solution is follow https://github.com/Azure/azure-sdk-for-python/tree/main/scripts/breaking_changes_checker#types-of-breaking-changes-detected to suppress each breaking item but it is not flexible. Is there any way I can only adopt the tool but not block SDK release?
The text was updated successfully, but these errors were encountered: