Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Service Resource Detector #31390

Closed
wants to merge 6 commits into from
Closed

App Service Resource Detector #31390

wants to merge 6 commits into from

Conversation

jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Jul 31, 2023 •
edited
Loading

Description

Add resource detector for azure app service. The .NET equivalent is here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.ResourceDetectors.Azure/AppServiceResourceDetector.cs

Testing on app service. Appears correctly:
image

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jul 31, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-opentelemetry-exporter

@jeremydvoss jeremydvoss marked this pull request as ready for review August 2, 2023 22:54
@jeremydvoss
Copy link
Member Author

Moving to https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/resource

@jeremydvoss jeremydvoss closed this Aug 3, 2023
@jeremydvoss
Copy link
Member Author

open-telemetry/opentelemetry-python-contrib#1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

@lzchen lzchen Awaiting requested review from lzchen lzchen is a code owner

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremydvoss @azure-sdk