-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to personal attributes #40078
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the evaluator from "ISAEvaluator" to "PersonalAttributesEvaluator" and updates its associated metrics, constants, and test references.
- Renames the evaluator class and updates its documentation and metric identifier.
- Adjusts constants and configuration to reflect the new personal attributes naming.
- Updates tests and simulator scenarios to use the new naming convention.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_personal_attributes/init.py | Adds an init file for the new PersonalAttributesEvaluator. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/init.py | Replaces references to ISAEvaluator with PersonalAttributesEvaluator. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_personal_attributes/_personal_attributes.py | No functional changes; updates documentation and evaluator identifier. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_common/_base_rai_svc_eval.py | Updates task mapping to use PERSONAL_ATTRIBUTES. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/rai_service.py | Updates metric handling and constant usage for the new evaluator. |
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_adversarial_scenario.py | Renames the adversarial scenario enum with the new evaluator name. |
sdk/evaluation/azure-ai-evaluation/_common/constants.py | Replaces ISA constant with PERSONAL_ATTRIBUTES constant. |
sdk/evaluation/azure-ai-evaluation/tests/e2etests/* | Updates tests to reference PersonalAttributesEvaluator and associated metric names. |
sdk/evaluation/azure-ai-evaluation/CHANGELOG.md | Reflects the new PersonalAttributesEvaluator and updated descriptions. |
Comments suppressed due to low confidence (3)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/rai_service.py:298
- Consider renaming or updating the constant 'INFERENCE_OF_SENSITIVE_ATTRIBUTES' to match the new 'PersonalAttributes' naming for consistency across the codebase.
if metric_name == EvaluationMetrics.PERSONAL_ATTRIBUTES and INFERENCE_OF_SENSITIVE_ATTRIBUTES in batch_response[0]:
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_adversarial_scenario.py:32
- [nitpick] The underlying string value 'adv_isa' has not been updated to reflect the new naming convention; consider changing it to 'adv_personal_attributes' for clarity.
ADVERSARIAL_PERSONAL_ATTRIBUTES = "adv_isa"
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/constants.py:43
- [nitpick] The constant value for PERSONAL_ATTRIBUTES still uses the legacy term 'inference sensitive attributes'; consider updating it to better reflect the personal attributes context.
PERSONAL_ATTRIBUTES = "inference sensitive attributes"
API change check APIView has identified API level changes in this PR and created following API reviews. |
No description provided.