-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] get_blob_properties
for BlobClient
#2014
Conversation
get_blob_properties
initial implementationget_blob_properties
for BlobClient
sdk/storage/azure_storage_blob/src/pipeline/storage_headers_policy.rs
Outdated
Show resolved
Hide resolved
sdk/storage/azure_storage_blob/src/pipeline/storage_headers_policy.rs
Outdated
Show resolved
Hide resolved
Hi @heaths Heath, I have documented the remaining 4 feedback items into my notes, and will address them in the following PR. I have commented out the testcases since they currently rely on static resources and have a hard dependency on some NYI functionality. With that in mind- please let me know if there is any other showstoppers in this specific PR. Thanks! |
I was under the impression this PR was no longer passing due to merging in |
Hi @heaths Heath, whenever you get a free moment if you could take a look at this to help resolve the CI issues and any merge-blocking stoppers. Thanks! |
@vincenttran-msft you need to fetch upstream/main and rebase on it. The issues you are running into were fixed in main. Don't merge, but rebase. |
2603d15
to
6c7c975
Compare
@heaths I have addressed your comments, rebased, and resolved the The remaining error is in the "Build Analyze" step, specifically Run source analysis:
It seems to be having issues while checking |
Building and testing all features in the workspace works fine on my machine. There were some changes that went in today that may fix them, though. Try rebasing again. |
The command failing here works fine on my box, and I just pulled upstream/main once again: cargo +stable clippy --target=wasm32-unknown-unknown --workspace --keep-going --no-deps You've been merging (in general, don't do that unless you're trying to main history for some reason), and I'm guessing you have a bad merge at some point. If all your changes have been under sdk/storage, I recommend from within your topic branch: git fetch upstream main
git rebase -X theirs upstream/main The problem you're running into is something I believe I fixed last Friday (was merged today, Monday). |
Also, I believe your merge is dirty because at one point |
@heaths Thanks for that callout. After merging and reverting the lockfile and doing a clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits/tips but nothing blocking. LGTM
This PR contains the following:
BlobClient
to supportget_blob_properties
get_blob_properties
and simple test cases (get properties with existing blob, container not exists case)