Skip to content

Add request and challenge callbacks to BearerTokenAuthorizationPolicy #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add request and challenge callbacks to BearerTokenAuthorizationPolicy #3368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4785d13
Add request and challenge callbacks to BearerTokenAuthorizationPolicy
chlowell Nov 20, 2025
7829590
remove Sealed reimplementation
chlowell Nov 21, 2025
b9bdaa4
reflow docs
chlowell Nov 21, 2025
dfe3453
propagate changelog entry
chlowell Nov 21, 2025
20ba17c
inline has_challenge
chlowell Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/core/azure_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
### Features Added

- Added `continuation_token` to `PagerOptions`.
- Added extensible request authorization and authentication challenge handling to `BearerTokenAuthorizationPolicy`.
- `OnRequest`, `OnChallenge`, and `Authorizer` traits define callbacks for these features.
- `with_on_request()` and `with_on_challenge()` builder methods set callbacks for a policy instance.
Comment on lines +8 to +10
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the coding guidelines, changes in sdk/core/typespec_client_core/CHANGELOG.md should be reflected in sdk/core/azure_core/CHANGELOG.md. The addition of Request::body_mut() documented in typespec_client_core/CHANGELOG.md should also be mentioned here since it's a public API change that affects azure_core users.

Copilot generated this review using guidance from repository custom instructions.
Copy link
Member

@heaths heaths Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot is right about the body_mut() call but, Copilot, you're wrong about the direction of changes reflecting in TSS to AC.

- Added `Request::body_mut()`.

### Breaking Changes

Expand Down
Loading