Closed
Conversation
cataggar
commented
Nov 16, 2021
| }) | ||
| } | ||
|
|
||
| pub struct Client(pub(crate) super::Client); |
Member
Author
There was a problem hiding this comment.
Follow new type pattern for modules.
Contributor
I'm not sure what a scope is; can you elaborate? |
cataggar
commented
Nov 16, 2021
Member
Author
|
With the pipeline, the user-agent header is set: Thanks @heaths! Can you verify the above is correct? Looks find to me. |
Member
|
Yep, looks good. Thanks! |
bmc-msft
reviewed
Nov 18, 2021
bmc-msft
reviewed
Nov 18, 2021
bmc-msft
approved these changes
Nov 18, 2021
Co-authored-by: bmc-msft <41130664+bmc-msft@users.noreply.github.com>
ctaggart
reviewed
Nov 25, 2021
| #[derive(Clone)] | ||
| pub struct Builder<'a> { | ||
| pub(crate) client: crate::operations::Client, | ||
| pub(crate) name: &'a str, |
Contributor
There was a problem hiding this comment.
If the Builder takes a lifetime, references can be passed in.
| } | ||
|
|
||
| impl<'a> Builder<'a> { | ||
| pub fn into_future(self) -> futures::future::BoxFuture<'a, std::result::Result<models::OperationList, Error>> { |
Contributor
There was a problem hiding this comment.
But then the future is limited to that lifetime. Is that okay or do we want a 'static lifetime?
Member
Author
There was a problem hiding this comment.
For #527, I left the parameters in Builder as owned so that the BoxFuture lifetime is 'static.
Member
Author
|
#527 is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to follow #510 for services by:
into_futureon the BuilderIt is also using
new typepattern for other sub-clients.