Skip to content

Commit

Permalink
Add support for Microsoft.KubernetesConfiguration/extensions (#3528)
Browse files Browse the repository at this point in the history
* Expand the selection criteria for extention resources while loading types

* WIP

* Update the reason

* Add samples and recordings

* Add header

* Update ref index

* Update HeadById to CheckExistenceWithGetByID in controller test

* Update generated files

* Use 2023-05-01 version

* Remove Statuses field from Spec

* Add todo for random name exclusion

* Rename v1api20221101_extension.yaml to v1api20230501_extension.yaml

* Update recording

* Update recording

* Fix test

* Fix command to create workload identity based kind cluster

* Needed a fix due to CLI updates.

---------

Co-authored-by: Matthew Christopher <[email protected]>
  • Loading branch information
super-harsh and matthchr authored Nov 14, 2023
1 parent 42cb425 commit 5949407
Show file tree
Hide file tree
Showing 31 changed files with 17,277 additions and 46 deletions.
12 changes: 12 additions & 0 deletions docs/hugo/content/reference/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,18 @@ These resource(s) are available for use in the current release of ASO. Different
|------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|----------------------|----------------|-----------------------------------------------------------------------------------------------------------------------------|
| [Vault](https://azure.github.io/azure-service-operator/reference/keyvault/v1api20210401preview/#keyvault.azure.com/v1api20210401preview.Vault) | 2021-04-01-preview | v1api20210401preview | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/keyvault/v1api/v1api20210401preview_vault.yaml) |

## KubernetesConfiguration

To install the CRDs for these resources, your ASO configuration must include `kubernetesconfiguration.azure.com/*` as a one of the configured CRD patterns. See [CRD Management in ASO](https://azure.github.io/azure-service-operator/guide/crd-management/) for details on doing this for both [Helm](https://azure.github.io/azure-service-operator/guide/crd-management/#helm) and [YAML](https://azure.github.io/azure-service-operator/guide/crd-management/#yaml) based installations.

### Next Release

Development of these new resources is complete and they will be available in the next release of ASO.

| Resource | ARM Version | CRD Version | Supported From | Sample |
|-----------|-------------|---------------|----------------|-----------------------------------------------------------------------------------------------------------------------------------------|
| Extension | 2023-05-01 | v1api20230501 | v2.4.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/kubernetesconfiguration/v1api/v1api20230501_extension.yaml) |

## MachineLearningServices

To install the CRDs for these resources, your ASO configuration must include `machinelearningservices.azure.com/*` as a one of the configured CRD patterns. See [CRD Management in ASO](https://azure.github.io/azure-service-operator/guide/crd-management/) for details on doing this for both [Helm](https://azure.github.io/azure-service-operator/guide/crd-management/#helm) and [YAML](https://azure.github.io/azure-service-operator/guide/crd-management/#yaml) based installations.
Expand Down
15 changes: 15 additions & 0 deletions docs/hugo/content/reference/kubernetesconfiguration/_index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
title: KubernetesConfiguration Supported Resources
linktitle: KubernetesConfiguration
no_list: true
---
To install the CRDs for these resources, your ASO configuration must include `kubernetesconfiguration.azure.com/*` as a one of the configured CRD patterns. See [CRD Management in ASO](https://azure.github.io/azure-service-operator/guide/crd-management/) for details on doing this for both [Helm](https://azure.github.io/azure-service-operator/guide/crd-management/#helm) and [YAML](https://azure.github.io/azure-service-operator/guide/crd-management/#yaml) based installations.

### Next Release

Development of these new resources is complete and they will be available in the next release of ASO.

| Resource | ARM Version | CRD Version | Supported From | Sample |
|-----------|-------------|---------------|----------------|-----------------------------------------------------------------------------------------------------------------------------------------|
| Extension | 2023-05-01 | v1api20230501 | v2.4.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/kubernetesconfiguration/v1api/v1api20230501_extension.yaml) |

3 changes: 2 additions & 1 deletion scripts/v2/make-mi-fic.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ set -o pipefail
function create_role_assignment() {
az role assignment create --assignee "${USER_ASSIGNED_OBJECT_ID}" \
--role "Owner" \
--subscription "${AZURE_SUBSCRIPTION_ID}"
--subscription "${AZURE_SUBSCRIPTION_ID}" \
--scope "/subscriptions/${AZURE_SUBSCRIPTION_ID}"
}

function retry_create_role_assignment() {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions v2/api/kubernetesconfiguration/customizations/structure.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Code generated by azure-service-operator-codegen. DO NOT EDIT.
github.com/Azure/azure-service-operator/v2/api/kubernetesconfiguration/customizations
└── ExtensionExtension: Object (0 properties)
10 changes: 10 additions & 0 deletions v2/api/kubernetesconfiguration/v1api20230501/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5949407

Please sign in to comment.