Xload prefetch initial code #1585
Conversation
…e-fuse into feature/xload
…to feature/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
…to sourav/xload
souravgupta-msft
requested review from
vibhansa-msft,
ashruti-msft,
syeleti-msft and
jainakanksha-msft
as code owners
| @@ -1080,14 +1079,14 @@ func (bb *BlockBlob) TruncateFile(name string, size int64) error { | |||
| blobClient := bb.Container.NewBlockBlobClient(blobName) | |||
|
|
|||
| blkList := make([]string, 0) | |||
| id := base64.StdEncoding.EncodeToString(common.NewUUIDWithLength(16)) | |||
| id := common.GetBlockID(16) | |||
There was a problem hiding this comment.
Should we consider declaring 16 as a constant. This approach would make it easier to update the value in the future, as it would only need to be changed in one place. Additionally, assigning it to a well-named constant would enhance readability for developers.
component/xload/block.go
Outdated
| data: addr, | ||
| offset: 0, | ||
| length: 0, | ||
| id: "", |
There was a problem hiding this comment.
Should we omit explicit assignments for default values (index: 0, offset: 0, etc.) as they are implicit in Go. This could make the code cleaner unless clarity is the goal.
component/xload/lister.go
Outdated
| Token: marker, | ||
| }) | ||
| if err != nil { | ||
| log.Err("remoteLister::process : Remote listing failed for %s [%s]", absPath, err.Error()) |
There was a problem hiding this comment.
If remote listing fails, should we continue from here?
| // TODO:: xload : should we delete the files from local path | ||
| err := common.TempCacheCleanup(xl.path) | ||
| if err != nil { | ||
| log.Err("unable to clean xload local path [%s]", err.Error()) |
There was a problem hiding this comment.
Should we return an error from this function? If not, can we remove the return type entirely since the function currently only returns nil.
✅ What
Initial code for prefetch feature in Xload component
🤔 Why
Download all the blobs on mount
NOTE
Please note that this the first PR for prefetch. Below items are in TODO list and will be added in future PRs