-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/res/cache/redis-enterprise
- Redis Enterprise and Azure Managed Redis (Preview)
#4114
base: main
Are you sure you want to change the base?
Conversation
a873c82
to
c100ac5
Compare
c100ac5
to
9e7eb8d
Compare
avm/res/cache/redis-enterprise/tests/e2e/kv-secrets/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
targetScope = 'subscription' | ||
|
||
metadata name = 'Azure Managed Redis (Preview)' | ||
metadata description = 'This instance deploys an Azure Managed Redis (Preview) cache with the minimum set of required parameters.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you call out "preview" - I recall that redis-enterprise
was already implemented in the CARML days but we had to 'retire' it. We documented it as a 'known issue' back then. @jtracey93 would you happen to know if we'd be able to deploy set resource in the AVM subscription? In the CARML one it was definitely not an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidenote: Added it to our agenda for tomorrow
avm/res/cache/redis-enterprise/tests/e2e/amr-entra-id/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/dependencies2.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create work @JeffreyCA, not much to call out :) Let me know if you have any questions regarding the comments.
If you addressed any please just comment them as such and I'll resolve them after a re-review.
Also, if you need help with the CI, let me know.
Description
Initial implementation of Bicep AVM for Redis Enterprise and Azure Managed Redis (Preview) caches (
Microsoft.Cache/redisEnterprise
).There is a related module,
avm/res/cache/redis
, that coversMicrosoft.Cache/redis
:avm/res/cache/redis
avm/res/cache/redis-enterprise
(this PR)Azure Managed Redis (Preview): Balanced, Compute Optimized, Flash Optimized, Memory Optimized
Closes Azure/Azure-Verified-Modules#1731.
Pipeline Reference
I'm facing issues setting up CI on my fork using my Azure subscription and Service Principal in the Microsoft tenant, but was able to validate all the E2E tests passed using
Test-ModuleLocally.ps1
.Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.