Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/cache/redis-enterprise - Redis Enterprise and Azure Managed Redis (Preview) #4114

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JeffreyCA
Copy link

@JeffreyCA JeffreyCA commented Dec 30, 2024

Description

Initial implementation of Bicep AVM for Redis Enterprise and Azure Managed Redis (Preview) caches (Microsoft.Cache/redisEnterprise).

There is a related module, avm/res/cache/redis, that covers Microsoft.Cache/redis:

Module Name Resource Type SKUs
avm/res/cache/redis Microsoft.Cache/redis OSS Redis: Basic, Standard, Premium
avm/res/cache/redis-enterprise (this PR) Microsoft.Cache/redisEnterprise Redis Enterprise: Enterprise, Enterprise Flash
Azure Managed Redis (Preview): Balanced, Compute Optimized, Flash Optimized, Memory Optimized

image

Closes Azure/Azure-Verified-Modules#1731.

Pipeline Reference

I'm facing issues setting up CI on my fork using my Azure subscription and Service Principal in the Microsoft tenant, but was able to validate all the E2E tests passed using Test-ModuleLocally.ps1.

image

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@JeffreyCA JeffreyCA requested review from a team as code owners December 30, 2024 22:00
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Dec 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 30, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jan 2, 2025
@JeffreyCA JeffreyCA force-pushed the cache/redis-enterprise branch 2 times, most recently from a873c82 to c100ac5 Compare January 9, 2025 00:40
@JeffreyCA JeffreyCA force-pushed the cache/redis-enterprise branch from c100ac5 to 9e7eb8d Compare January 9, 2025 01:20
targetScope = 'subscription'

metadata name = 'Azure Managed Redis (Preview)'
metadata description = 'This instance deploys an Azure Managed Redis (Preview) cache with the minimum set of required parameters.'
Copy link
Contributor

@AlexanderSehr AlexanderSehr Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you call out "preview" - I recall that redis-enterprise was already implemented in the CARML days but we had to 'retire' it. We documented it as a 'known issue' back then. @jtracey93 would you happen to know if we'd be able to deploy set resource in the AVM subscription? In the CARML one it was definitely not an option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote: Added it to our agenda for tomorrow

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create work @JeffreyCA, not much to call out :) Let me know if you have any questions regarding the comments.
If you addressed any please just comment them as such and I'll resolve them after a re-review.

Also, if you need help with the CI, let me know.

@AlexanderSehr AlexanderSehr self-assigned this Jan 9, 2025
@AlexanderSehr AlexanderSehr added the Class: Resource Module 📦 This is a resource module label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: avm/res/cache/redis-enterprise
2 participants