Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: StoraegAccount - Add possibility to specify CORS rules for file services & queue. #4117

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: StoraegAccount - Add possibility to specify CORS rules for file services & queue. #4117

wants to merge 9 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 2, 2025 •
edited
Loading

Description

  • Added support for CORSRules to File & Queue Services
  • Added test cases
  • Added UDT for CORSRules
  • Updated current implementation of CORSRules in Storage Accout BlobServices to avoid overwriting current settings by default (tested)

Re-Based from PR : #3862

Pipeline Reference

Pipeline
avm.res.storage.storage-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

headcr4sh and others added 3 commits January 2, 2025 10:56
@headcr4sh
feat: Add possibility to specify CORS rules for file services.
fea5899 
Implementation of the feature is aligned with how CORS rules configuration
has been implemented for the BLOB service.

Closes Azure#3861
@headcr4sh
Merge branch 'main' into feature/3861
749d2c3
@AlexanderSehr
Rebased PR & added UDTs & implementation for corsRules to all support…
3935587 
…ed children
@AlexanderSehr AlexanderSehr self-assigned this Jan 2, 2025
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Resource Module 📦 This is a resource module labels Jan 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 2, 2025
@AlexanderSehr AlexanderSehr mentioned this pull request Jan 2, 2025
Closed
11 tasks
@AlexanderSehr AlexanderSehr linked an issue Jan 2, 2025 that may be closed by this pull request
[AVM Module Issue]: Storage Account Table Service Cors #3209
Open
1 task
@AlexanderSehr AlexanderSehr linked an issue Jan 2, 2025 that may be closed by this pull request
[AVM Module Issue]: Unable to set corsRules of managed fileService when using res/storage/storage-account module #3861
Open
1 task
@AlexanderSehr AlexanderSehr marked this pull request as ready for review January 2, 2025 15:38
@AlexanderSehr AlexanderSehr requested review from a team as code owners January 2, 2025 15:38
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 2, 2025 15:39
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jan 2, 2025
@AlexanderSehr AlexanderSehr changed the title feat: Add possibility to specify CORS rules for file services & queue. feat: StoraegAccount - Add possibility to specify CORS rules for file services & queue. Jan 2, 2025
@AlexanderSehr
Copy link
Contributor Author

Hey @ktremain, please review this PR when you get the chance 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headcr4sh headcr4sh headcr4sh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
2 participants
@AlexanderSehr @headcr4sh